Page MenuHomePhabricator
Differential D7471

[native] migrate message store threads to SQLite
ClosedPublic
Actions

Authored by kamil on Apr 17 2023, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:59 AM
Unknown Object (File)
Tue, Apr 8, 10:54 PM
Unknown Object (File)
Tue, Apr 8, 10:36 PM
Unknown Object (File)
Tue, Apr 8, 10:30 PM
Unknown Object (File)
Mar 16 2025, 4:21 AM
Unknown Object (File)
Mar 6 2025, 2:58 PM
Unknown Object (File)
Mar 6 2025, 4:17 AM
Unknown Object (File)
Mar 5 2025, 1:47 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMM0b8d068678e7: [native] migrate message store threads to SQLite
Summary

Migrating rehydrated store to SQLite database.

Depends on D7470

Test Plan

Check if migration succeeded:

image.png (41×445 px, 6 KB)

And if database content equals redux state (from redux-devtools)

image.png (601×874 px, 88 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 17 2023, 11:18 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 17 2023, 11:18 AM
kamil added a child revision: D7472: [CommCoreModule] implement logic to get message store threads from SQLite.Apr 17 2023, 11:33 AM
kamil edited the test plan for this revision. (Show Details)Apr 17 2023, 11:35 AM
Harbormaster completed remote builds in B18416: Diff 25227.Apr 17 2023, 11:36 AM
kamil published this revision for review.Apr 18 2023, 2:56 AM
tomek accepted this revision.Apr 20 2023, 7:48 AM
tomek added inline comments.
native/redux/persist.js
510

In other migrations that populated the db, we were adding a remove operation as the first one. Should we something similar here?

This revision is now accepted and ready to land.Apr 20 2023, 7:48 AM
kamil updated this revision to Diff 25499.Apr 21 2023, 2:35 AM

remove operation

native/redux/persist.js
510

I think this is not needed as I wanted to land the entire stack at once but I'll add this to match the convention

Harbormaster completed remote builds in B18613: Diff 25499.Apr 21 2023, 2:52 AM
Closed by commit rCOMM0b8d068678e7: [native] migrate message store threads to SQLite (authored by kamil). · Explain WhyApr 21 2023, 3:11 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0b8d068678e7: [native] migrate message store threads to SQLite.

Revision Contents
Changeset List

PathSize
native/
redux/
27 lines

Diff 25227

View Options

native/redux/persist.js

Loading...