[native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 10:43 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMca2c754b086c: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`

Summary

Pull out common functionality from Edit[User/Thread]Avatar and move to newly introduced avatar-hooks.js.

Test Plan

Replace onPressEmojiAvatarFlow with openPhotoGallery in Edit[User/Thread]Avatar
Ensure that selected image appears in keyserver uploads table as before.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2023, 10:43 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 10:43 AM

atul added inline comments.Apr 18 2023, 10:45 AM

native/avatars/avatar-hooks.js
11 ↗	(On Diff #25291)	Placing this in `native/avatars/avatar-hooks` for now because `openPhotoGallery` has some native-specific code. It is true that `useUploadProcessedMedia` and `useProcessSelectedMedia` (next diff) could also be useful for `web` and so it might make sense for them to live in `lib`... but I think we can defer that for later. Right now it's convenient to have them all in one file, and because of `openPhotoGallery` it makes sense for that one file to be within `native`.

Harbormaster completed remote builds in B18465: Diff 25291.Apr 18 2023, 11:01 AM

atul requested review of this revision.Apr 18 2023, 11:01 AM

atul added a child revision: D7497: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.Apr 18 2023, 12:04 PM

atul retitled this revision from [native] Pull `useUploadProcessedMedia` out of `[User/Thread]Avatar` to [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`.Apr 18 2023, 12:28 PM

atul edited the summary of this revision. (Show Details)

ashoat accepted this revision.Apr 18 2023, 1:11 PM

ashoat added inline comments.