[native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 12:01 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM61f134825fab: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`

Summary

Pull out common functionality from Edit[User/Thread]Avatar and move to newly introduced avatar-hooks.js.

Depends on D7493

Test Plan

Replace onPressEmojiAvatarFlow with openPhotoGallery in Edit[User/Thread]Avatar
Ensure that selection is processed correctly (logging + breakpoint)
Ensure that selected image appears in keyserver uploads table as before

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2023, 12:01 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 12:01 PM

atul published this revision for review.Apr 18 2023, 12:02 PM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D7493: [native] Pull `useUploadProcessedMedia` out of `Edit[User/Thread]Avatar`.

Harbormaster completed remote builds in B18470: Diff 25296.Apr 18 2023, 12:19 PM

atul added a child revision: D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.Apr 18 2023, 12:27 PM

atul retitled this revision from [native] Pull `useProcessSelectedMedia` out of `[User/Thread]Avatar` to [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.Apr 18 2023, 12:27 PM

atul edited the summary of this revision. (Show Details)

ashoat accepted this revision.Apr 18 2023, 1:09 PM

This revision is now accepted and ready to land.Apr 18 2023, 1:09 PM

Closed by commit rCOMM61f134825fab: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar` (authored by atul). · Explain WhyApr 18 2023, 1:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM61f134825fab: [native] Pull `useProcessSelectedMedia` out of `Edit[User/Thread]Avatar`.