Pull out common functionality from Edit[User/Thread]Avatar and move to newly introduced avatar-hooks.js.
Added entry to editAvatarOptions in both components to consume this hook.
Depends on D7497
Details
Details
- Click on pencil icon
- Ensure that the system media gallery appears as expected
- Ensure that the selection is processed as expected (logging + breakpoint)
- Ensure that selected image appears in keyserver uploads table:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/avatars/edit-user-avatar.react.js | ||
|---|---|---|
| 25 ↗ | (On Diff #25298) | For now useSelectAndUploadFromGallery just returns the function that launches that media gallery and processes + uploads the selection. In the future it'll probably also return some information about progress. |
| native/avatars/edit-thread-avatar.react.js | ||
|---|---|---|
| 46–50 ↗ | (On Diff #25298) | Here's how things looks on Android. I think we should use emote-smile for consistency for emoji  |
Comment Actions
Assuming this is a clean refactor so only skimmed it
| native/avatars/edit-thread-avatar.react.js | ||
|---|---|---|
| 46–50 ↗ | (On Diff #25298) | What does emote-smile look like? Agree this doesn't look great |
| native/avatars/edit-user-avatar.react.js | ||
| 25 ↗ | (On Diff #25298) | Makes sense. Not sure if the "information about progress" will be returned by the call to useSelectAndUploadFromGallery() or the call to selectAndUploadFromGallery(), but I think the latter makes more sense since there's no progress to speak of in the former |
| 41–52 ↗ | (On Diff #25298) | Thank you for adding this! |