Page MenuHomePhabricator
Differential D7502

[native] Pull `EditAvatarBadge` into its own component
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 6:22 AM
Unknown Object (File)
Wed, Apr 2, 8:37 PM
Unknown Object (File)
Wed, Apr 2, 4:22 AM
Unknown Object (File)
Mar 2 2025, 7:35 AM
Unknown Object (File)
Mar 2 2025, 7:35 AM
Unknown Object (File)
Mar 2 2025, 2:52 AM
Unknown Object (File)
Feb 16 2025, 9:49 PM
Unknown Object (File)
Feb 13 2025, 6:02 PM
View All 75 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM343b90fb639a: [native] Pull `EditAvatarBadge` into its own component
Summary

Pulling out some more that's in common between EditUserAvatar and EditThreadAvatar.

Depends on D7499

Test Plan

Things continue to work and look as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 25309

View Options

native/avatars/edit-avatar-badge.react.js

// @flow // @flow
import classnames from 'classnames'; import classnames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js'; import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import type { CommunityDrawerItemHandler } from './community-drawer-item-handler.react.js';
import type { HandlerProps } from './community-drawer-item-handlers.react.js'; import type { HandlerProps } from './community-drawer-item-handlers.react.js';
import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js'; import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js';
import css from './community-drawer-item.css'; import css from './community-drawer-item.css';
import { import {
getChildren, getChildren,
getExpandButton, getExpandButton,
} from './community-drawer-utils.react.js'; } from './community-drawer-utils.react.js';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
Show All 9 Lines
function CommunityDrawerItem(props: DrawerItemProps): React.Node { function CommunityDrawerItem(props: DrawerItemProps): React.Node {
const { const {
itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle }, itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle },
paddingLeft, paddingLeft,
expandable = true, expandable = true,
handlerType, handlerType,
} = props; } = props;
const [handler, setHandler] = React.useState({ const [handler, setHandler] = React.useState<CommunityDrawerItemHandler>({
onClick: () => {}, onClick: () => {},
expanded: false, expanded: false,
toggleExpanded: () => {}, toggleExpanded: () => {},
isActive: false,
}); });
const Handler = getCommunityDrawerItemHandler(handlerType); const Handler = getCommunityDrawerItemHandler(handlerType);
const children = React.useMemo( const children = React.useMemo(
() => () =>
getChildren({ getChildren({
expanded: handler.expanded, expanded: handler.expanded,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

native/avatars/edit-thread-avatar.react.js

// @flow // @flow
import classnames from 'classnames'; import classnames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js'; import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import type { CommunityDrawerItemHandler } from './community-drawer-item-handler.react.js';
import type { HandlerProps } from './community-drawer-item-handlers.react.js'; import type { HandlerProps } from './community-drawer-item-handlers.react.js';
import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js'; import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js';
import css from './community-drawer-item.css'; import css from './community-drawer-item.css';
import { import {
getChildren, getChildren,
getExpandButton, getExpandButton,
} from './community-drawer-utils.react.js'; } from './community-drawer-utils.react.js';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
Show All 9 Lines
function CommunityDrawerItem(props: DrawerItemProps): React.Node { function CommunityDrawerItem(props: DrawerItemProps): React.Node {
const { const {
itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle }, itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle },
paddingLeft, paddingLeft,
expandable = true, expandable = true,
handlerType, handlerType,
} = props; } = props;
const [handler, setHandler] = React.useState({ const [handler, setHandler] = React.useState<CommunityDrawerItemHandler>({
onClick: () => {}, onClick: () => {},
expanded: false, expanded: false,
toggleExpanded: () => {}, toggleExpanded: () => {},
isActive: false,
}); });
const Handler = getCommunityDrawerItemHandler(handlerType); const Handler = getCommunityDrawerItemHandler(handlerType);
const children = React.useMemo( const children = React.useMemo(
() => () =>
getChildren({ getChildren({
expanded: handler.expanded, expanded: handler.expanded,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

native/avatars/edit-user-avatar.react.js

// @flow // @flow
import classnames from 'classnames'; import classnames from 'classnames';
import * as React from 'react'; import * as React from 'react';
import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js'; import type { CommunityDrawerItemData } from 'lib/utils/drawer-utils.react.js';
import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js'; import { useResolvedThreadInfo } from 'lib/utils/entity-helpers.js';
import type { CommunityDrawerItemHandler } from './community-drawer-item-handler.react.js';
import type { HandlerProps } from './community-drawer-item-handlers.react.js'; import type { HandlerProps } from './community-drawer-item-handlers.react.js';
import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js'; import { getCommunityDrawerItemHandler } from './community-drawer-item-handlers.react.js';
import css from './community-drawer-item.css'; import css from './community-drawer-item.css';
import { import {
getChildren, getChildren,
getExpandButton, getExpandButton,
} from './community-drawer-utils.react.js'; } from './community-drawer-utils.react.js';
import ThreadAvatar from '../avatars/thread-avatar.react.js'; import ThreadAvatar from '../avatars/thread-avatar.react.js';
Show All 9 Lines
function CommunityDrawerItem(props: DrawerItemProps): React.Node { function CommunityDrawerItem(props: DrawerItemProps): React.Node {
const { const {
itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle }, itemData: { threadInfo, itemChildren, hasSubchannelsButton, labelStyle },
paddingLeft, paddingLeft,
expandable = true, expandable = true,
handlerType, handlerType,
} = props; } = props;
const [handler, setHandler] = React.useState({ const [handler, setHandler] = React.useState<CommunityDrawerItemHandler>({
onClick: () => {}, onClick: () => {},
expanded: false, expanded: false,
toggleExpanded: () => {}, toggleExpanded: () => {},
isActive: false,
}); });
const Handler = getCommunityDrawerItemHandler(handlerType); const Handler = getCommunityDrawerItemHandler(handlerType);
const children = React.useMemo( const children = React.useMemo(
() => () =>
getChildren({ getChildren({
expanded: handler.expanded, expanded: handler.expanded,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines