[native] Create invitation modal
ClosedPublic
Actions

Authored by tomek on Apr 19 2023, 5:34 AM.

Details

Reviewers

bartek
kamil
inka

Commits

rCOMM6725c0b6164d: [native] Create invitation modal

Summary

After user clicks a link, we're going to call link verification endpoint. Based on the result, we will navigate user to this modal.

Depends on D7522

Test Plan

Open a link that:

is valid => user should see two buttons, one for joining and one for canceling
is invalid => user should see an error message
points to a community where the user is a member => modal should not be displayed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 19 2023, 5:34 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 19 2023, 5:34 AM

tomek added inline comments.Apr 19 2023, 5:34 AM

native/navigation/invite-link-modal.react.js
62 ↗	(On Diff #25339)	This function is introduced in later diff

tomek edited the summary of this revision. (Show Details)Apr 19 2023, 5:39 AM

Harbormaster completed remote builds in B18503: Diff 25339.Apr 19 2023, 6:03 AM

tomek requested review of this revision.Apr 19 2023, 6:03 AM

Would it make sense to add an invariant to check that this modal is not called with `status: 'already_joined'? Currently there is nothing stopping someone from doing that, because there is no type checking. And the modal would be displayed without errors, with a message that would be incorrect and misleading.

tomek added a child revision: D7525: [keyserver] Introduce invite link handler.Apr 19 2023, 9:49 AM

bartek accepted this revision.Apr 21 2023, 2:25 AM

This revision is now accepted and ready to land.Apr 21 2023, 2:25 AM

In D7524#223171, @inka wrote:

Would it make sense to add an invariant to check that this modal is not called with `status: 'already_joined'? Currently there is nothing stopping someone from doing that, because there is no type checking. And the modal would be displayed without errors, with a message that would be incorrect and misleading.

Yeah, adding some validation is a good idea!

Do not show a modal in already_joined state

In D7524#226197, @tomek wrote:

In D7524#223171, @inka wrote:

Would it make sense to add an invariant to check that this modal is not called with `status: 'already_joined'? Currently there is nothing stopping someone from doing that, because there is no type checking. And the modal would be displayed without errors, with a message that would be incorrect and misleading.

Yeah, adding some validation is a good idea!

Instead of using an invariant I decided that we can simply close the modal. This is consistent with our approach that a modal shouldn't be opened when a user is a member of the community.

Harbormaster failed remote builds in B18807: Diff 25765!Apr 26 2023, 7:05 AM

Rebase

Harbormaster completed remote builds in B18814: Diff 25774.Apr 26 2023, 1:06 PM

Closed by commit rCOMM6725c0b6164d: [native] Create invitation modal (authored by tomek). · Explain WhyApr 27 2023, 7:15 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM6725c0b6164d: [native] Create invitation modal.