[native] Handle error state when joining a community
ClosedPublic
Actions

Authored by tomek on Apr 21 2023, 11:06 AM.

Details

Reviewers

bartek
kamil
inka

Commits

rCOMMecb0feb66ee3: [native] Handle error state when joining a community

Summary

When an error occurs, we're updating the params to let the user know that the link is invalid. This isn't ideal, as the error might be caused by e.g. a timeout and a link is still valid, but it is by far the simplest solution.

Depends on D7558

Test Plan

Introduce a sleep on server side and the throw. Check if the error state becomes enabled.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 21 2023, 11:06 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 11:06 AM

tomek edited the summary of this revision. (Show Details)Apr 21 2023, 11:07 AM

Rethrow

Harbormaster completed remote builds in B18622: Diff 25512.Apr 21 2023, 11:24 AM

Harbormaster completed remote builds in B18623: Diff 25513.

tomek requested review of this revision.Apr 21 2023, 11:26 AM

bartek added inline comments.Apr 25 2023, 3:41 AM

native/navigation/invite-link-modal.react.js
106 ↗	(On Diff #25513)	Where this rethrow is caught?

ashoat added inline comments.Apr 25 2023, 10:52 AM

native/navigation/invite-link-modal.react.js
106 ↗	(On Diff #25513)	Since it is dispatched by `dispatchActionPromise`, it gets caught here: https://github.com/CommE2E/comm/blob/master/lib/utils/action-utils.js#L88