Page MenuHomePhabricator
Differential D7559

[native] Handle error state when joining a community
ClosedPublic
Actions

Authored by tomek on Apr 21 2023, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 19, 7:27 PM
Unknown Object (File)
Sun, May 19, 5:45 PM
Unknown Object (File)
Sun, May 19, 5:45 PM
Unknown Object (File)
Sun, May 19, 5:45 PM
Unknown Object (File)
Sun, May 19, 5:45 PM
Unknown Object (File)
Sat, May 18, 12:21 AM
Unknown Object (File)
Thu, May 16, 12:18 AM
Unknown Object (File)
Apr 15 2024, 3:34 AM
View All 54 Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMMecb0feb66ee3: [native] Handle error state when joining a community
Summary

When an error occurs, we're updating the params to let the user know that the link is invalid. This isn't ideal, as the error might be caused by e.g. a timeout and a link is still valid, but it is by far the simplest solution.

Depends on D7558

Test Plan

Introduce a sleep on server side and the throw. Check if the error state becomes enabled.

Diff Detail

Repository
rCOMM Comm
Branch
invite2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Apr 21 2023, 4:06 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 4:06 AM
tomek edited the summary of this revision. (Show Details)Apr 21 2023, 4:07 AM
tomek updated this revision to Diff 25513.Apr 21 2023, 4:09 AM

Rethrow

Harbormaster completed remote builds in B18622: Diff 25512.Apr 21 2023, 4:24 AM
Harbormaster completed remote builds in B18623: Diff 25513.
tomek requested review of this revision.Apr 21 2023, 4:26 AM
bartek added inline comments.Apr 24 2023, 8:41 PM
native/navigation/invite-link-modal.react.js
106

Where this rethrow is caught?

ashoat added inline comments.Apr 25 2023, 3:52 AM
native/navigation/invite-link-modal.react.js
106

Since it is dispatched by dispatchActionPromise, it gets caught here: https://github.com/CommE2E/comm/blob/master/lib/utils/action-utils.js#L88

bartek accepted this revision.Apr 25 2023, 4:20 AM
bartek added inline comments.
native/navigation/invite-link-modal.react.js
106

Ah right, I missed the dispatchActionPromise, thanks for the explanation!

This revision is now accepted and ready to land.Apr 25 2023, 4:20 AM
tomek updated this revision to Diff 25779.Apr 26 2023, 12:53 PM

Rebase

Harbormaster completed remote builds in B18819: Diff 25779.Apr 26 2023, 1:11 PM
Closed by commit rCOMMecb0feb66ee3: [native] Handle error state when joining a community (authored by tomek). · Explain WhyApr 27 2023, 7:15 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMecb0feb66ee3: [native] Handle error state when joining a community.

Revision Contents
Changeset List

PathSize
native/
navigation/
38 lines

Diff 25513

View Options

native/navigation/invite-link-modal.react.js

Loading...