[native] Make RegistrationContainer scrollable
ClosedPublic
Actions

Authored by ashoat on Apr 24 2023, 1:36 PM.

Details

Reviewers

ginsu
atul

Commits

Summary

This diff does two things:

Makes RegistrationContainer scrollable, so if there isn't enough space in the viewport, the content can still be fully viewable
Add KeyboardAvoidingView to the RegistrationContainer, following the approach in Profile. This way when a TextInput is focused and the keyboard comes up, the ScrollView automatically adjusts so that the TextInput is still visible on screen

Depends on D7592

Test Plan

(I also tested the same thing on Android)

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 1:38 PM

ashoat requested review of this revision.Apr 24 2023, 1:55 PM

ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 1:56 PM

Had to move the KeyboardAvoidingView into the RegistrationContainer so that:

It plays nice with SafeAreaView, which is introduced in D7599. The issue is that if the KeyboardAvoidingView is outside the SafeAreaView, it applies the bottom inset ABOVE the keyboard
It doesn't move the RegistrationButton up. I want that button to stay below the keyboard