Details
Details
before | after |
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
As of my most recent updates to D7593, the RegistrationContainer now handles scrolling, so we now need to wrap it with a container View.
Two opinionated things I did here:
- I opted to leave the padding in RegistrationContainer inside of moving it to the parent View, since I figured it would be good to have that extra vertical padding inside the ScrollView. I could separate the vertical padding and horizontal padding if desired, with the horizontal padding applied by the parent component but the vertical padding applied by the RegistrationContainer
- Decided to leave the RegistrationContainer changes here, even though they're no longer used. Figured it might be used in other cases. Can remove it (or separate into another diff) if desired