Page MenuHomePhabricator
Differential D7592

[native] Connect selection state with TextInput state in KeyserverSelection
ClosedPublic
Actions

Authored by ashoat on Apr 24 2023, 1:36 PM.
Tags
None
Referenced Files
F3174860: D7592.id25629.diff
Thu, Nov 7, 6:33 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:50 PM
Unknown Object (File)
Fri, Oct 11, 11:40 PM
Unknown Object (File)
Sep 20 2024, 2:21 PM
View All 86 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM7efe015177f4: [native] Connect selection state with TextInput state in KeyserverSelection
Summary

Three changes:

  1. When the "Ashoat" option is selected, we blur the custom option's TextInput
  2. When the custom option's TextInput is focused, we select that option
  3. When the custom option is selected, we focus that TextInput if it's empty
Test Plan

(I also tested the same thing on Android)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 24 2023, 1:36 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 24 2023, 1:36 PM
ashoat added a child revision: D7593: [native] Make RegistrationContainer scrollable.Apr 24 2023, 1:36 PM
ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 1:37 PM
ashoat updated this revision to Diff 25627.Apr 24 2023, 1:51 PM

Remove extraneous console.log

Harbormaster completed remote builds in B18709: Diff 25622.Apr 24 2023, 1:54 PM
ashoat edited the test plan for this revision. (Show Details)Apr 24 2023, 1:56 PM
ashoat updated this revision to Diff 25629.Apr 24 2023, 1:59 PM

Avoid redefining selectCustom every time customKeyserver changes

Harbormaster completed remote builds in B18714: Diff 25627.Apr 24 2023, 2:09 PM
Harbormaster completed remote builds in B18716: Diff 25629.Apr 24 2023, 2:17 PM
ashoat requested review of this revision.Apr 24 2023, 2:17 PM
atul accepted this revision.Apr 25 2023, 1:57 PM
This revision is now accepted and ready to land.Apr 25 2023, 1:57 PM
Closed by commit rCOMM7efe015177f4: [native] Connect selection state with TextInput state in KeyserverSelection (authored by ashoat). · Explain WhyApr 26 2023, 1:23 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7efe015177f4: [native] Connect selection state with TextInput state in KeyserverSelection.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
15 lines

Diff 25787

View Options

native/account/registration/keyserver-selection.react.js

Loading...