Paths

Table of Contentst

Differential D7597

[native] Add button to KeyserverSelection
ClosedPublic
Actions

Authored by ashoat on Apr 25 2023, 12:35 AM.

Tags

None

Referenced Files

	F506274: Screenshot 2023-04-24 at 8.34.37 PM.png
	Apr 25 2023, 12:43 AM

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMM4f0be980351c: [native] Add button to KeyserverSelection

Summary

Introduces a new RegistrationButton component and adds it to KeyserverSelection. See designs

Depends on D7593

Test Plan

Screenshot 2023-04-24 at 8.34.37 PM.png (1×1 px, 793 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2023, 12:35 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 12:35 AM

ashoat added a child revision: D7598: [native] Position RegistrationButton at the bottom of KeyserverSelection.Apr 25 2023, 12:36 AM

ashoat added inline comments.Apr 25 2023, 12:42 AM

native/components/button.react.js
25 ↗	(On Diff #25633)	This change is unrelated. `*` is the same as `any` in modern versions of Flow. `() => mixed` is the right type here, and it introduces no errors

ashoat edited the test plan for this revision. (Show Details)Apr 25 2023, 12:43 AM

Harbormaster completed remote builds in B18720: Diff 25633.Apr 25 2023, 12:53 AM

ashoat requested review of this revision.Apr 25 2023, 12:53 AM

Rebase

atul accepted this revision.Apr 25 2023, 9:08 PM

This revision is now accepted and ready to land.Apr 25 2023, 9:08 PM

Harbormaster completed remote builds in B18770: Diff 25717.Apr 25 2023, 9:22 PM

Closed by commit rCOMM4f0be980351c: [native] Add button to KeyserverSelection. · Explain WhyApr 26 2023, 8:23 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4f0be980351c: [native] Add button to KeyserverSelection.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

keyserver-selection.react.js

4 lines

registration-button.react.js

36 lines

components/

button.react.js

2 lines

Diff 25789

native/account/registration/keyserver-selection.react.js

Loading...

native/account/registration/registration-button.react.js

Loading...

native/components/button.react.js

Loading...