Page MenuHomePhabricator

[native] Add a pin/unpin icon in the tooltip
ClosedPublic

Authored by rohan on Apr 25 2023, 5:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 8:57 AM
Unknown Object (File)
Mon, Oct 28, 6:39 AM
Unknown Object (File)
Tue, Oct 22, 8:23 PM
Unknown Object (File)
Sep 28 2024, 8:26 AM
Unknown Object (File)
Sep 28 2024, 8:26 AM
Unknown Object (File)
Sep 28 2024, 8:26 AM
Unknown Object (File)
Sep 28 2024, 8:26 AM
Unknown Object (File)
Sep 28 2024, 8:22 AM
Subscribers

Details

Summary

The tooltip icon to pin / unpin messages should appear for
composable messages (multimedia and text, not robotext). Functionality for
pressing the icon will be added in the next diff.

Note: These icons do need to be modified a bit, I believe Ted said that
the icons for native should just be the outline and unfilled.

Test Plan

Confirm that the tooltip icons appear for the messages that
should have them

Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.18.png (2×1 px, 342 KB)

Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.25.png (2×1 px, 944 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Apr 25 2023, 6:05 AM
tomek added inline comments.
native/chat/multimedia-message-tooltip-modal.react.js
58 ↗(On Diff #25658)

Should we have separate functions for pin / unpin? I think it might be beneficial, because it protects against clicking the button multiple times in short period.

This revision is now accepted and ready to land.Apr 28 2023, 4:58 AM

Use the correct pin icons