Page MenuHomePhabricator
Differential D7608

[native] Render the message inside of the pin modal
ClosedPublic
Actions

Authored by rohan on Apr 25 2023, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:48 PM
Unknown Object (File)
Mon, Mar 17, 8:47 PM
Unknown Object (File)
Mon, Mar 17, 8:34 PM
View All Files
Subscribers
ashoat
atul
inka
tomek

Details

Reviewers
atul
ginsu
tomek
ashoat
Commits
rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal
Summary

Following the previous diff, the target message that the user is trying to pin should render inside of the toggle pin modal.

Depends on D7607

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Apr 25 2023, 6:06 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 6:06 AM
rohan edited the summary of this revision. (Show Details)Apr 25 2023, 6:06 AM
rohan added a parent revision: D7607: [native] Create the toggle pin modal.
Harbormaster completed remote builds in B18736: Diff 25660.Apr 25 2023, 6:22 AM
rohan requested review of this revision.Apr 25 2023, 6:22 AM
rohan added a child revision: D7614: [native] Display the number of pinned messages in a banner across chat.Apr 25 2023, 10:28 AM
inka added a subscriber: inka.Apr 27 2023, 3:16 AM
rohan updated this revision to Diff 26019.May 2 2023, 1:11 PM

Rebase

rohan retitled this revision from [DRAFT] [native] Render the message inside of the pin modal to [native] Render the message inside of the pin modal.May 2 2023, 1:14 PM
rohan edited the summary of this revision. (Show Details)
rohan edited the test plan for this revision. (Show Details)
rohan added reviewers: atul, ginsu, tomek.
rohan attached a referenced file: F519860: Simulator Screen Recording - iPhone 14 Pro - 2023-05-02 at 16.13.47.mp4. (Show Details)
Harbormaster completed remote builds in B18999: Diff 26019.May 2 2023, 1:32 PM
atul accepted this revision.May 3 2023, 7:48 AM

Looks okay at a high level, adding @ashoat as blocking since I'm not super familiar with navigation (particularly wrt flow types)

native/chat/message-result.react.js
25 ↗(On Diff #26019)

I'd maybe put a console.log("UNIMPLEMENTED") inside the body or have a TODO comment in the future?

Just to make things clearer to reader if this stack is partially landed or whatever. Probably fine to leave as-is for now.

This revision is now accepted and ready to land.May 3 2023, 7:48 AM
atul added a reviewer: ashoat.May 3 2023, 7:49 AM
This revision now requires review to proceed.May 3 2023, 7:49 AM
ashoat added a comment.May 3 2023, 7:53 AM

Nav stuff looks fine. For more context on ReactNav Flow types, you can read this blog post

ashoat accepted this revision.May 3 2023, 7:54 AM
This revision is now accepted and ready to land.May 3 2023, 7:54 AM
rohan updated this revision to Diff 26135.May 5 2023, 4:25 PM

Update styling

Harbormaster completed remote builds in B19087: Diff 26135.May 5 2023, 4:43 PM
rohan updated this revision to Diff 26216.May 8 2023, 11:40 AM

Import ScrollView from react-native-gesture-handler (fixes scroll on
Android)

Harbormaster completed remote builds in B19146: Diff 26216.May 8 2023, 12:01 PM
rohan updated this revision to Diff 26224.May 8 2023, 12:06 PM

Rebase

Harbormaster completed remote builds in B19153: Diff 26224.May 8 2023, 12:31 PM
Closed by commit rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal (authored by RohanK6 <rohan.khanderia@gmail.com>, committed by rohan). · Explain WhyMay 8 2023, 12:38 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal.

Revision Contents
Changeset List

Diff 26232

View Options

native/chat/message-result.react.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm
View Options

native/chat/message.react.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm
View Options

native/chat/robotext-message.react.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm
View Options

native/chat/text-message.react.js

  • This file was added.
#pragma once
#include <grpcpp/grpcpp.h>
#include <iostream>
#include <memory>
#include <string>
namespace comm {
namespace network {
namespace reactor {
struct ServerBidiReactorStatus {
grpc::Status status = grpc::Status::OK;
bool sendLastResponse = false;
ServerBidiReactorStatus(
grpc::Status status = grpc::Status::OK,
bool sendLastResponse = false)
: status(status), sendLastResponse(sendLastResponse) {
}
};
template <class Request, class Response>
class ServerBidiReactorBase
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
protected:
ServerBidiReactorStatus status;
bool readingAborted = false;
public:
ServerBidiReactorBase();
void OnDone() override;
void OnReadDone(bool ok) override;
void OnWriteDone(bool ok) override;
void terminate(ServerBidiReactorStatus status);
virtual std::unique_ptr<ServerBidiReactorStatus>
handleRequest(Request request, Response *response) = 0;
virtual void initialize(){};
virtual void doneCallback(){};
};
template <class Request, class Response>
ServerBidiReactorBase<Request, Response>::ServerBidiReactorBase() {
this->initialize();
this->StartRead(&this->request);
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnDone() {
this->doneCallback();
delete this;
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::terminate(
ServerBidiReactorStatus status) {
this->status = status;
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnReadDone(bool ok) {
if (!ok) {
this->readingAborted = true;
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "no more reads")));
return;
}
try {
this->response = Response();
std::unique_ptr<ServerBidiReactorStatus> status =
this->handleRequest(this->request, &this->response);
if (status != nullptr) {
this->terminate(*status);
return;
}
this->StartWrite(&this->response);
} catch (std::runtime_error &e) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::INTERNAL, e.what())));
}
}
template <class Request, class Response>
void ServerBidiReactorBase<Request, Response>::OnWriteDone(bool ok) {
if (!ok) {
this->terminate(ServerBidiReactorStatus(
grpc::Status(grpc::StatusCode::ABORTED, "write failed")));
return;
}
this->StartRead(&this->request);
}
} // namespace reactor
} // namespace network
} // namespace comm
View Options

native/chat/toggle-pin-modal.react.js

Loading...