Paths

Table of Contentst

Differential D7608

[native] Render the message inside of the pin modal
ClosedPublic
Actions

Authored by rohan on Apr 25 2023, 6:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 11:02 AM

	Unknown Object (File)
	Sun, Nov 24, 10:42 AM

	Unknown Object (File)
	Sun, Nov 24, 9:46 AM

	Unknown Object (File)
	Sun, Nov 24, 9:30 AM

	Unknown Object (File)
	Sun, Nov 24, 9:28 AM

	Unknown Object (File)
	Sun, Nov 24, 9:22 AM

	Unknown Object (File)
	Sun, Nov 24, 7:52 AM

	Unknown Object (File)
	Oct 28 2024, 6:39 AM

Subscribers

Details

Reviewers

atul
ginsu
tomek
ashoat

Commits

rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal

Summary

Following the previous diff, the target message that the user is trying to pin should render inside of the toggle pin modal.

Depends on D7607

Test Plan

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Apr 25 2023, 6:06 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 6:06 AM

rohan edited the summary of this revision. (Show Details)Apr 25 2023, 6:06 AM

rohan added a parent revision: D7607: [native] Create the toggle pin modal.

Harbormaster completed remote builds in B18736: Diff 25660.Apr 25 2023, 6:22 AM

rohan requested review of this revision.Apr 25 2023, 6:22 AM

rohan added a child revision: D7614: [native] Display the number of pinned messages in a banner across chat.Apr 25 2023, 10:28 AM

inka added a subscriber: inka.Apr 27 2023, 3:16 AM

Rebase

rohan retitled this revision from [DRAFT] [native] Render the message inside of the pin modal to [native] Render the message inside of the pin modal.May 2 2023, 1:14 PM

rohan edited the summary of this revision. (Show Details)

rohan edited the test plan for this revision. (Show Details)

rohan added reviewers: atul, ginsu, tomek.

rohan attached a referenced file: F519860: Simulator Screen Recording - iPhone 14 Pro - 2023-05-02 at 16.13.47.mp4. (Show Details)

Harbormaster completed remote builds in B18999: Diff 26019.May 2 2023, 1:32 PM

Looks okay at a high level, adding @ashoat as blocking since I'm not super familiar with navigation (particularly wrt flow types)

native/chat/message-result.react.js
25 ↗	(On Diff #26019)	I'd maybe put a `console.log("UNIMPLEMENTED")` inside the body or have a `TODO` comment in the future? Just to make things clearer to reader if this stack is partially landed or whatever. Probably fine to leave as-is for now.

This revision is now accepted and ready to land.May 3 2023, 7:48 AM

atul added a reviewer: ashoat.May 3 2023, 7:49 AM

This revision now requires review to proceed.May 3 2023, 7:49 AM

Nav stuff looks fine. For more context on ReactNav Flow types, you can read this blog post

ashoat accepted this revision.May 3 2023, 7:54 AM

This revision is now accepted and ready to land.May 3 2023, 7:54 AM

Update styling

Harbormaster completed remote builds in B19087: Diff 26135.May 5 2023, 4:43 PM

Import ScrollView from react-native-gesture-handler (fixes scroll on
Android)

Harbormaster completed remote builds in B19146: Diff 26216.May 8 2023, 12:01 PM

Rebase

Harbormaster completed remote builds in B19153: Diff 26224.May 8 2023, 12:31 PM

Closed by commit rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal (authored by RohanK6 <rohan.khanderia@gmail.com>, committed by rohan). · Explain WhyMay 8 2023, 12:38 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM4d2b8d7399f1: [native] Render the message inside of the pin modal.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-result.react.js

54 lines

message.react.js

7 lines

robotext-message.react.js

7 lines

text-message.react.js

7 lines

toggle-pin-modal.react.js

7 lines

Diff 26216

native/chat/message-result.react.js

Loading...

native/chat/message.react.js

Loading...

native/chat/robotext-message.react.js

Loading...

native/chat/text-message.react.js

Loading...

native/chat/toggle-pin-modal.react.js

Loading...