[native] Add a pin/unpin icon in the tooltip
ClosedPublic
Actions

Authored by rohan on Apr 25 2023, 5:47 AM.

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMMa5d44ee240be: [native] Add a pin/unpin icon in the tooltip

Summary

The tooltip icon to pin / unpin messages should appear for
composable messages (multimedia and text, not robotext). Functionality for
pressing the icon will be added in the next diff.

Note: These icons do need to be modified a bit, I believe Ted said that
the icons for native should just be the outline and unfilled.

Test Plan

Confirm that the tooltip icons appear for the messages that
should have them

Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.18.png (2×1 px, 342 KB)

Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.25.png (2×1 px, 944 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Apr 25 2023, 5:47 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 25 2023, 5:47 AM

rohan edited the test plan for this revision. (Show Details)Apr 25 2023, 5:49 AM

rohan attached a referenced file: F507370: Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.18.png. (Show Details)

rohan attached a referenced file: F507371: Simulator Screen Shot - iPhone 14 Pro - 2023-04-25 at 08.49.25.png. (Show Details)

rohan added a child revision: D7607: [native] Create the toggle pin modal.Apr 25 2023, 5:56 AM

Harbormaster completed remote builds in B18734: Diff 25658.Apr 25 2023, 6:05 AM

rohan requested review of this revision.Apr 25 2023, 6:05 AM

tomek accepted this revision.Apr 28 2023, 4:58 AM

tomek added inline comments.

native/chat/multimedia-message-tooltip-modal.react.js
58 ↗	(On Diff #25658)	Should we have separate functions for pin / unpin? I think it might be beneficial, because it protects against clicking the button multiple times in short period.