Details
Details
- Reviewers
ashoat atul - Commits
- rCOMM8766591c33ca: [lib] Shim Blob service hosted multimedia
- Artifically replaced each URI parameter in keyserver upload-fetchers with fake Blob service URIs
- Log out and back in on native
- Verify that shim message is displayed
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Mainly concerned about codeVersion check
| lib/media/media-utils.js | ||
|---|---|---|
| 42–43 ↗ | (On Diff #25690) | Why do we have to check both uri and holder? |
| lib/shared/messages/multimedia-message-spec.js | ||
| 230 ↗ | (On Diff #25690) | Is this the right codeVersion? I believe this version has already launched, and I don't think it supports querying https://blob.commtechnologies.org... Can we set this to some large number? Could be a good time to address ENG-2019 (should take a second) |
| lib/media/media-utils.js | ||
|---|---|---|
| 42–43 ↗ | (On Diff #25690) | Ah, I forgot to mention here. It's the same case as I described in https://phab.comm.dev/D7617#inline-49702 We're not going to set non-encrypted media uri to be a blob service holder, but support for this and additional checks won't hurt |
| lib/shared/messages/multimedia-message-spec.js | ||
| 230 ↗ | (On Diff #25690) | Yeah I got too late with this, 214 already on TestFlight today That constant is a great idea, will do! |