[native] Add UUID dependency
ClosedPublic
Actions

Authored by bartek on Apr 27 2023, 4:01 AM.

Details

Reviewers

ashoat

Commits

rCOMMa2e3c4b79bce: [native] Add UUID dependency

Summary

As discussed in ENG-3534, blob holder for encrypted media will be a UUID.

Added the uuid dependency. Ran yarn why uuid and saw that both web and keyserver already resolve to uuid@3.4.0, as well as the expo library so sticked to the same version to keep consistent and avoid conflicts. Only updated all of them to ^3.4.0 to keep consistent

Newer versions mostly introduce breaking changes: mainly ESM, way of importing and greatly increase package size so I see no point forcing them (also IDK if they're compatible with Metro)

Test Plan

yarn cleaninstall. Native bundle loads. Console.log uuid.v4() works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 27 2023, 4:01 AM

bartek held this revision as a draft.

Herald added subscribers: atul, tomek. · View Herald TranscriptApr 27 2023, 4:01 AM

Harbormaster completed remote builds in B18842: Diff 25811.Apr 27 2023, 4:18 AM

bartek added a child revision: D7649: [native] Add function to upload media to blob service.Apr 27 2023, 4:23 AM

bartek published this revision for review.Apr 27 2023, 4:29 AM

We appear to use another version in other package.json files (3.3.3), but in yarn.lock it resolves to the same version:

uuid@^3.3.2, uuid@^3.3.3, uuid@^3.4.0:
  version "3.4.0"
  resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.4.0.tgz#b23e4358afa8a202fe7a100af1f5f883f02007ee"
  integrity sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A==

Could potentially be good to update the other package.jsons to have the same version number for consistency

This revision is now accepted and ready to land.Apr 27 2023, 8:12 AM

Update web and keyserver uuid to 3.4.0 for consistency

bartek edited the summary of this revision. (Show Details)Apr 29 2023, 9:09 AM

Harbormaster completed remote builds in B18936: Diff 25935.Apr 29 2023, 9:26 AM

Rebase before landing

Harbormaster completed remote builds in B19121: Diff 26175.May 8 2023, 4:23 AM

Closed by commit rCOMMa2e3c4b79bce: [native] Add UUID dependency (authored by bartek). · Explain WhyMay 8 2023, 4:47 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa2e3c4b79bce: [native] Add UUID dependency.