Details
- Reviewers
atul marcin - Commits
- rCOMM1cced606957b: [web] Upload encrypted media to Blob service
Set the useBlobServiceUploads to true. Send a message with single and multiple images. Verify they're sent successfully. Verify Blob service content (S3 + DynamoDB) and keyserver uploads table.
When the pending upload is deleted (user clicks the cross in the corner of selected img), the blob is removed from blob servic of selected img), the blob is removed from blob service
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Accepting, but would be good to double check that you intended to set useBlobServiceUploads to true here.
Can we update encrypt_data step in lib/types/media-types.js now?
web/input/input-state-container.react.js | ||
---|---|---|
187 ↗ | (On Diff #25939) | On native, we set this to false. Was setting it to true here intentional? |
787–796 ↗ | (On Diff #25939) | Think we can make these changes? |
Just realized that it needs to be nullable for failure cases - we cannot set it non-null when encryption fails
web/input/input-state-container.react.js | ||
---|---|---|
187 ↗ | (On Diff #25939) | My bad, should be false |