Page MenuHomePhabricator

[web] Upload encrypted media to Blob service
ClosedPublic

Authored by bartek on Apr 29 2023, 9:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 12:35 PM
Unknown Object (File)
Thu, Oct 31, 5:30 PM
Unknown Object (File)
Mon, Oct 28, 1:45 AM
Unknown Object (File)
Mon, Oct 28, 1:45 AM
Unknown Object (File)
Mon, Oct 28, 1:45 AM
Unknown Object (File)
Mon, Oct 28, 1:45 AM
Unknown Object (File)
Mon, Oct 28, 1:45 AM
Unknown Object (File)
Mon, Oct 28, 1:43 AM
Subscribers

Details

Summary

Web counterpart of D7650. This diff that enables encrypted media uploads to Blob service on web.
I decided to hide this feature behind a boolean flag to be able to easily flip the switch.

Depends on D7688, D7689

Test Plan

Set the useBlobServiceUploads to true. Send a message with single and multiple images. Verify they're sent successfully. Verify Blob service content (S3 + DynamoDB) and keyserver uploads table.
When the pending upload is deleted (user clicks the cross in the corner of selected img), the blob is removed from blob servic of selected img), the blob is removed from blob service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Apr 29 2023, 9:34 AM

Accepting, but would be good to double check that you intended to set useBlobServiceUploads to true here.

Can we update encrypt_data step in lib/types/media-types.js now?

871975.png (546×2 px, 109 KB)

web/input/input-state-container.react.js
187 ↗(On Diff #25939)

On native, we set this to false. Was setting it to true here intentional?

787–796 ↗(On Diff #25939)

Think we can make these changes?

This revision is now accepted and ready to land.May 3 2023, 11:36 AM
In D7690#228657, @atul wrote:

Can we update encrypt_data step in lib/types/media-types.js now?

Just realized that it needs to be nullable for failure cases - we cannot set it non-null when encryption fails

web/input/input-state-container.react.js
187 ↗(On Diff #25939)

My bad, should be false