[web] Upload encrypted media to Blob service
ClosedPublic
Actions

Authored by bartek on Apr 29 2023, 9:23 AM.

Details

Reviewers

atul
marcin

Commits

rCOMM1cced606957b: [web] Upload encrypted media to Blob service

Summary

Web counterpart of D7650. This diff that enables encrypted media uploads to Blob service on web.
I decided to hide this feature behind a boolean flag to be able to easily flip the switch.

Depends on D7688, D7689

Test Plan

Set the useBlobServiceUploads to true. Send a message with single and multiple images. Verify they're sent successfully. Verify Blob service content (S3 + DynamoDB) and keyserver uploads table.
When the pending upload is deleted (user clicks the cross in the corner of selected img), the blob is removed from blob servic of selected img), the blob is removed from blob service

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 29 2023, 9:23 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 29 2023, 9:23 AM

bartek published this revision for review.Apr 29 2023, 9:34 AM

Harbormaster completed remote builds in B18940: Diff 25939.Apr 29 2023, 9:40 AM

Accepting, but would be good to double check that you intended to set useBlobServiceUploads to true here.

Can we update encrypt_data step in lib/types/media-types.js now?

web/input/input-state-container.react.js
187 ↗	(On Diff #25939)	On `native`, we set this to `false`. Was setting it to `true` here intentional?
787–796 ↗	(On Diff #25939)	Think we can make these changes?