Page MenuHomePhabricator
Differential D7615

[lib] Add Blob service utils
ClosedPublic
Actions

Authored by bartek on Apr 25 2023, 10:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 7:47 PM
Unknown Object (File)
Wed, Dec 11, 7:46 PM
Unknown Object (File)
Sat, Dec 7, 7:50 PM
Unknown Object (File)
Thu, Dec 5, 12:22 AM
Unknown Object (File)
Thu, Dec 5, 12:22 AM
Unknown Object (File)
Thu, Dec 5, 12:22 AM
Unknown Object (File)
Thu, Dec 5, 12:21 AM
Unknown Object (File)
Thu, Dec 5, 12:21 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
marcin
ashoat
Commits
rCOMM8829e72a0ac3: [lib] Add Blob service utils
Summary

As decided in ENG-3534, we will use the comm-blob-service:// URI prefix for BLob service hosted media. This diff adds some utilities that will be used later to deal with these URIs.

Also added the Blob service config to lib/facts directory, inspired by the lib/facts/feature-flags.js.

Test Plan

Did some console.log to ensure they're working. These functions will be used and better tested in further diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Apr 25 2023, 10:44 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 10:44 AM
bartek added a child revision: D7616: [lib] Shim Blob service hosted multimedia.Apr 25 2023, 10:49 AM
Harbormaster completed remote builds in B18748: Diff 25687.Apr 25 2023, 11:02 AM
bartek published this revision for review.Apr 25 2023, 11:34 AM
ashoat accepted this revision.Apr 25 2023, 12:38 PM
This revision is now accepted and ready to land.Apr 25 2023, 12:38 PM
bartek updated this revision to Diff 25804.Apr 27 2023, 3:46 AM

Rebase. Added utils and constants for HTTP endpoints

Harbormaster completed remote builds in B18835: Diff 25804.Apr 27 2023, 4:04 AM
ashoat added inline comments.Apr 27 2023, 12:11 PM
lib/utils/blob-service.js
32 ↗(On Diff #25804)

Always good to make input parameters read-only

bartek updated this revision to Diff 25932.Apr 29 2023, 8:46 AM

Make type read-only

Harbormaster completed remote builds in B18933: Diff 25932.Apr 29 2023, 9:04 AM
bartek updated this revision to Diff 26171.May 8 2023, 4:02 AM

Rebase before landing

Harbormaster completed remote builds in B19117: Diff 26171.May 8 2023, 4:20 AM
Closed by commit rCOMM8829e72a0ac3: [lib] Add Blob service utils (authored by bartek). · Explain WhyMay 8 2023, 4:47 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM8829e72a0ac3: [lib] Add Blob service utils.

Revision Contents
Changeset List

PathSize
lib/
facts/
32 lines
utils/
54 lines

Diff 26184

View Options

lib/facts/blob-service.js

Loading...
View Options

lib/utils/blob-service.js

Loading...