Page MenuHomePhabricator
Differential D7686

[native] Add disabled state to RegistrationButton
ClosedPublic
Actions

Authored by ashoat on Apr 29 2023, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 8:00 PM
Unknown Object (File)
Thu, Oct 24, 8:35 AM
Unknown Object (File)
Thu, Oct 24, 8:35 AM
Unknown Object (File)
Tue, Oct 22, 5:34 PM
Unknown Object (File)
Tue, Oct 22, 5:34 PM
Unknown Object (File)
Tue, Oct 22, 12:32 PM
Unknown Object (File)
Tue, Oct 22, 12:32 PM
Unknown Object (File)
Tue, Oct 22, 5:01 AM
View All 95 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton
Summary

We'll use this until somebody selects an option in the KeyserverSelection page. See designs here.

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 29 2023, 8:42 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 29 2023, 8:42 AM
ashoat edited the test plan for this revision. (Show Details)Apr 29 2023, 8:43 AM
ashoat added inline comments.
native/themes/colors.js
106 ↗(On Diff #25931)

I discussed this with Ted and we agreed that introducing a new color here is the right approach. This corresponds to disabledButton, and is in our design system

Harbormaster completed remote builds in B18932: Diff 25931.Apr 29 2023, 9:00 AM
ashoat requested review of this revision.Apr 29 2023, 9:00 AM
ginsu accepted this revision.Apr 30 2023, 10:19 PM
This revision is now accepted and ready to land.Apr 30 2023, 10:19 PM
Closed by commit rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton (authored by ashoat). · Explain WhyMay 1 2023, 5:09 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
9 lines
33 lines
themes/
2 lines

Diff 25960

View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/registration-button.react.js

Loading...
View Options

native/themes/colors.js

Loading...