If we're going to return result.updates (CreateUpdatesResult) in `updateUserAvatar(...), shouldn't we leave this matching?

I think we want to have different types for the keyserver return on the keyserver side vs the payload on the client... the keyserver return will have an optional avatarInfo in there, but the client payload should just be an object that contains a single property, which is updates: CreateUpdatesResult. So basically:

export type UpdateUserAvatarResponse = {
  +avatarInfo?: ClientAvatarInfo,
  +updates?: CreateUpdatesResult,
};
export type UpdateUserAvatarResult = {
  +updates: CreateUpdatesResult,
};

With UpdateUserAvatarResult being both the return of the action function in lib/actions, as wella as the payload used here.

I don't think we need avatarInfo in UpdateUserAvatarResponse? I'm not sure I'm following

On keyserver:

• For old clients we need to return ?ClientAvatar directly. We can't retroactively wrap it in a UpdateUserAvatarResponse?
• For new clients we want to return CreateUpdatesResult wrapped in UpdateUserAvatarResponse. There's no need for avatarInfo because it's included in the updates?

I think we need to return ?ClientAvatar | UpdateUserAvatarResult(as UpdateUserAvatarResult is defined above) on the keyserver and type action function return type and payload in redux-types as UpdateUserAvatarResult? I'm not sure we need to do the following:

Let's explicitly return a property of the object rather than the whole thing

in updateUserAvatar?