Page MenuHomePhabricator
Differential D7790

[native] Added animation to the edit box when entering/leaving edit mode
ClosedPublic
Actions

Authored by • kuba on May 11 2023, 2:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 1:08 AM
Unknown Object (File)
Tue, Apr 8, 11:18 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Wed, Apr 2, 11:27 AM
Unknown Object (File)
Fri, Mar 21, 2:56 PM
Unknown Object (File)
Mar 13 2025, 9:03 PM
Unknown Object (File)
Mar 13 2025, 9:03 PM
Unknown Object (File)
Mar 13 2025, 9:03 PM
View All 95 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
inka
michal
Commits
rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode
Summary

Added appearning and disappearing animation to the edit message box in edit mode.

Test Plan

Run the app. Check the animations.

Videos: (might look a little bit laggy on simulator, didn't have access to physical devices)

iOS:

Android:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• kuba created this revision.May 11 2023, 2:30 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMay 11 2023, 2:30 AM
• kuba added a parent revision: D7789: [native] Introduced new types for Reanimated.May 11 2023, 2:31 AM
• kuba added a child revision: D7791: [native] Added animation to the highlight of edited message.
• kuba edited the test plan for this revision. (Show Details)
• kuba edited the test plan for this revision. (Show Details)May 11 2023, 2:34 AM
• kuba edited the test plan for this revision. (Show Details)
• kuba mentioned this in D7791: [native] Added animation to the highlight of edited message.
Harbormaster completed remote builds in B19264: Diff 26366.May 11 2023, 2:47 AM
• kuba requested review of this revision.May 11 2023, 2:47 AM
ashoat accepted this revision.May 12 2023, 2:15 AM
This revision is now accepted and ready to land.May 12 2023, 2:15 AM
Closed by commit rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 22 2023, 7:05 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> mentioned this in rCOMM204fc8185ca8: [native] Added animation to the highlight of edited message.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMee38c51336f4: [native] Added animation to the edit box when entering/leaving edit mode.

Revision Contents
Changeset List

PathSize
native/
chat/
16 lines

Diff 26789

View Options

native/chat/chat-input-bar.react.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };