Differential D7798

Change properties of olm account updater so that the callback can use pickling key as well
ClosedPublic
Actions

Authored by marcin on May 11 2023, 8:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 19, 1:41 PM

	Unknown Object (File)
	Sat, Apr 19, 1:59 AM

	Unknown Object (File)
	Fri, Apr 18, 8:57 PM

	Unknown Object (File)
	Fri, Apr 18, 2:16 PM

	Unknown Object (File)
	Fri, Apr 18, 1:35 PM

	Unknown Object (File)
	Sat, Apr 12, 2:14 AM

	Unknown Object (File)
	Wed, Apr 9, 1:13 AM

	Unknown Object (File)
	Tue, Apr 8, 11:09 PM

Subscribers

Details

Reviewers

tomek
bartek
atul
ashoat

Commits

rCOMMf812588bef5a: Change properties of olm account updater so that the callback can use pickling…

Summary

This differential changes signature of olm updater so that the callback can use the pickling key.

Test Plan

Execute test plans for: D7568 and D7631

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.May 11 2023, 8:04 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 11 2023, 8:04 AM

marcin added a parent revision: D7586: Implement endpoint on the keyserver to get one time keys and prekey to initialize olmsession.May 11 2023, 8:04 AM

marcin added a child revision: D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.

Harbormaster completed remote builds in B19293: Diff 26407.May 11 2023, 8:22 AM

marcin requested review of this revision.May 11 2023, 8:22 AM

ashoat accepted this revision.May 12 2023, 9:31 AM

This revision is now accepted and ready to land.May 12 2023, 9:31 AM

Rebase before landing

Harbormaster completed remote builds in B19557: Diff 26738.May 22 2023, 2:05 AM

Rebase before landing

Harbormaster completed remote builds in B19838: Diff 27169.May 29 2023, 11:50 AM

Closed by commit rCOMMf812588bef5a: Change properties of olm account updater so that the callback can use pickling… (authored by marcin). · Explain WhyMay 29 2023, 1:41 PM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMf812588bef5a: Change properties of olm account updater so that the callback can use pickling….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

olm-account-updater.js

4 lines

Diff 26738

keyserver/src/updaters/olm-account-updater.js

	Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines		return {
	...draftStore,			...draftStore,
	drafts: {			drafts: {
	...draftsWithoutOldKey,			...draftsWithoutOldKey,
	[newKey]: text,			[newKey]: text,
	},			},
	},			},
	};			};
	} else if (action.type === setClientDBStoreActionType) {			} else if (action.type === setClientDBStoreActionType) {
	const drafts = {};			const drafts: { [string]: string } = {};
	for (const dbDraftInfo of action.payload.drafts) {			for (const dbDraftInfo of action.payload.drafts) {
	drafts[dbDraftInfo.key] = dbDraftInfo.text;			drafts[dbDraftInfo.key] = dbDraftInfo.text;
	}			}
	return {			return {
	draftStoreOperations: [],			draftStoreOperations: [],
	draftStore: {			draftStore: {
	...draftStore,			...draftStore,
	drafts: drafts,			drafts: drafts,
	},			},
	};			};
	}			}
	return { draftStore, draftStoreOperations: [] };			return { draftStore, draftStoreOperations: [] };
	}			}

	export { reduceDraftStore };			export { reduceDraftStore };