Page MenuHomePhabricator
Differential D7853

Create new olm session during invalidated cookie resolution
ClosedPublic
Actions

Authored by marcin on May 17 2023, 5:15 AM.
Tags
None
Referenced Files
F1668012: D7853.id26753.diff
Fri, Apr 26, 2:56 PM
Unknown Object (File)
Mon, Apr 15, 3:56 PM
Unknown Object (File)
Mon, Apr 15, 3:55 PM
Unknown Object (File)
Mon, Apr 15, 3:48 PM
Unknown Object (File)
Mon, Apr 15, 3:40 PM
Unknown Object (File)
Mon, Apr 15, 5:50 AM
Unknown Object (File)
Mon, Apr 15, 1:04 AM
Unknown Object (File)
Mon, Apr 15, 12:57 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
bartek
Commits
rCOMM71a5db08b388: Create new olm session during invalidated cookie resolution
rCOMMd6cf5bc0332a: Create new olm session during invalidated cookie resolution
Summary

This differential implements new olm session establishment on native during invalidated cookie resolution.

Test Plan
  1. Go to the socket.react.js file in lib.
  2. Inside a function initializeSocket throw an error under await this.sendInitialMessage();.
  3. Change this.failuresAfterPolicyAcknowledgment >= 2 condition to this.failuresAfterPolicyAcknowledgment >= 0.

Now we will be repeatbedly calling socketCrashLoopRecivery() which calls resolveInvalidatedCookie.

  1. In regular intervals issue select * from olm_sessions; query. Ensure new entries appear in the database.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.May 17 2023, 5:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 17 2023, 5:15 AM
marcin updated this revision to Diff 26608.May 17 2023, 5:16 AM

Rebase to update commit message

Harbormaster completed remote builds in B19447: Diff 26608.May 17 2023, 5:34 AM
marcin requested review of this revision.May 17 2023, 5:34 AM
Harbormaster completed remote builds in B19446: Diff 26607.May 17 2023, 5:36 AM
ashoat added inline comments.May 17 2023, 12:51 PM
native/account/resolve-invalidated-cookie.js
19 ↗(On Diff #26608)

Accidental console.log was left here

marcin added a parent revision: D7669: Establish olm notifs sessions during siwe account creation.May 18 2023, 5:41 AM
marcin added a child revision: D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.
tomek accepted this revision.May 22 2023, 2:00 AM
tomek added inline comments.
lib/socket/socket.react.js
108 ↗(On Diff #26608)
native/account/logged-out-modal.react.js
785–802 ↗(On Diff #26608)

Rename?

This revision is now accepted and ready to land.May 22 2023, 2:00 AM
marcin updated this revision to Diff 26753.May 22 2023, 3:31 AM

Rename call to get and rebaew before landing

Harbormaster completed remote builds in B19572: Diff 26753.May 22 2023, 3:49 AM
marcin updated this revision to Diff 27175.May 29 2023, 11:36 AM

Rebase before landing

Harbormaster completed remote builds in B19844: Diff 27175.May 29 2023, 12:09 PM
Closed by commit rCOMMd6cf5bc0332a: Create new olm session during invalidated cookie resolution (authored by marcin). · Explain WhyMay 29 2023, 1:41 PM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMd6cf5bc0332a: Create new olm session during invalidated cookie resolution.
marcin added a reverting change: rCOMM10c52a02d3ba: Revert "Create new olm session during invalidated cookie resolution".May 31 2023, 6:00 AM
marcin reopened this revision.May 31 2023, 8:37 AM
This revision is now accepted and ready to land.May 31 2023, 8:37 AM
marcin updated this revision to Diff 27343.Jun 1 2023, 6:09 AM

Rebase before landing

Harbormaster completed remote builds in B19953: Diff 27343.Jun 1 2023, 6:30 AM
Closed by commit rCOMM71a5db08b388: Create new olm session during invalidated cookie resolution (authored by marcin). · Explain WhyJun 1 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM71a5db08b388: Create new olm session during invalidated cookie resolution.

Revision Contents
Changeset List

PathSize
lib/
socket/
3 lines
utils/
2 lines
1 line
native/
account/
9 lines
10 lines
data/
12 lines
8 lines

Diff 27214

View Options

lib/socket/socket.react.js

Loading...
View Options

lib/utils/action-utils.js

Loading...
View Options

lib/utils/config.js

Loading...
View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/account/resolve-invalidated-cookie.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/socket.react.js

Loading...