Now that web will have a version we need to handle it in hasMinCodeVersion. It now takes two version, one for native and one for web. If either of them is absent we treat it like all versions of the respective platform are allowed.
Details
Details
yarn flow-all and check if web app works fine.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Do we still have places where we don't use hasMinCodeVersion function? Do we have to update these?
| lib/shared/version-utils.js | ||
|---|---|---|
| 13 ↗ | (On Diff #26614) | Isn't it simpler to use optionals directly? |
Comment Actions
Do we still have places where we don't use hasMinCodeVersion function? Do we have to update these?
The only place I could find was when sending notifications in send.js. They are all separated by platform so there shouldn't be a conflict between web and native. The only place that could break is that we would be using the web version for sending notifs to the desktop, fix: D7903.
| lib/shared/version-utils.js | ||
|---|---|---|
| 13 ↗ | (On Diff #26614) | ashoat suggested $Shape on our 1-1 |