[web] Send platform details on websocket connection
ClosedPublic
Actions

Authored by michal on May 17 2023, 5:31 AM.

Details

Reviewers

kamil
tomek

Commits

Summary

Now it makes sense to send it on websocket connection to update the server on the web app version.

Depends on D7854

Test Plan

Run production version of the web app so there's no hot reloading.

run the web app, check the db cookie table if it has no version
update registerConfig in app.react.js to contain platformDetails with the version
reload the web app, check if there's new version in the db

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

michal requested review of this revision.May 17 2023, 5:49 AM

keyserver/src/socket/socket.js
469–478 ↗	(On Diff #26619)	This was added to update the platform of the desktop apps from `web` to `macos`/`windows`. It will be better handled by sending the platform details during web socket initialization.

tomek requested changes to this revision.May 19 2023, 1:32 AM

tomek added inline comments.

keyserver/src/socket/socket.js
469–478 ↗	(On Diff #26619)	Does it require adding some code instead of this one? Or just removing it and modifying the `initialPlatformDetailsSent` condition does the job?

This revision now requires changes to proceed.May 19 2023, 1:32 AM

michal requested review of this revision.May 19 2023, 3:40 AM

michal added inline comments.

keyserver/src/socket/socket.js
469–478 ↗	(On Diff #26619)	`initialPlatformDetailsSent` is enough (this is probably how I should have done this from the beginning). The previous flow looked like this: client sends initialization -> server responds with request from platform details (if electron) -> client responds with platform details Now every client will just include platform details in the initialization message.