Page MenuHomePhabricator

[keyserver] Don't use web version when sending desktop notifs
ClosedPublic

Authored by michal on May 22 2023, 5:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 7:42 PM
Unknown Object (File)
Fri, Mar 8, 12:00 AM
Unknown Object (File)
Thu, Mar 7, 5:45 AM
Unknown Object (File)
Thu, Mar 7, 5:45 AM
Unknown Object (File)
Feb 27 2024, 4:31 AM
Unknown Object (File)
Feb 27 2024, 4:31 AM
Unknown Object (File)
Feb 27 2024, 4:31 AM
Unknown Object (File)
Feb 27 2024, 4:28 AM
Subscribers

Details

Summary

For windows and macos we don't want to use the web's codeVersion when sending notifs. This diff keeps the previous behaviour of keeping the codeVersion as -1 in case of desktop notifs. Made a task for handling desktop versions on the keyserver: ENG-3917

Depends on D7855

Test Plan

Set web version, try sending a macOS notification. Check if the codeVersion in the notifications table is -1.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Are you sure about this? Don't we need both web (js code) version and desktop (electron)?

This revision is now accepted and ready to land.May 23 2023, 2:02 AM

Are you sure about this? Don't we need both web (js code) version and desktop (electron)?

Not sure what you mean. Currently, both web and desktop notifs work with -1 as their codeVersion. When we start versioning web we want to keep the desktop version as -1. In the future when we make keyserver aware of desktop version (https://linear.app/comm/issue/ENG-3917) we can make the windows/macos notifs use both web and desktop versions for sending notifs. If we wanted to this now we would have to introduce some webVersion for windows/macos handlers, but I don't that's needed now.