[keyserver] Don't use web version when sending desktop notifs
ClosedPublic
Actions

Authored by michal on May 22 2023, 5:26 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM96629ccbc982: [keyserver] Don't use web version when sending desktop notifs

Summary

For windows and macos we don't want to use the web's codeVersion when sending notifs. This diff keeps the previous behaviour of keeping the codeVersion as -1 in case of desktop notifs. Made a task for handling desktop versions on the keyserver: ENG-3917

Depends on D7855

Test Plan

Set web version, try sending a macOS notification. Check if the codeVersion in the notifications table is -1.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.May 22 2023, 5:26 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 5:26 AM

michal mentioned this in D7854: [keyserver] Handle web version in hasMinCodeVersion.May 22 2023, 5:27 AM

Harbormaster completed remote builds in B19580: Diff 26763.May 22 2023, 5:44 AM

michal requested review of this revision.May 22 2023, 5:44 AM

Are you sure about this? Don't we need both web (js code) version and desktop (electron)?

This revision is now accepted and ready to land.May 23 2023, 2:02 AM

Are you sure about this? Don't we need both web (js code) version and desktop (electron)?

Not sure what you mean. Currently, both web and desktop notifs work with -1 as their codeVersion. When we start versioning web we want to keep the desktop version as -1. In the future when we make keyserver aware of desktop version (https://linear.app/comm/issue/ENG-3917) we can make the windows/macos notifs use both web and desktop versions for sending notifs. If we wanted to this now we would have to introduce some webVersion for windows/macos handlers, but I don't that's needed now.