This differential handles client response to initial notifications encrypted message request by creating new olm session for notifs.
Details
- Log out.
- Comment the code in log in panel that creates olm session for notifs.
- Log in.
- Query select * from olm_sessions and ensure there is a new entry for notifs
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D7654
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Added @atul as blocking reviewer for entire substack since he implemented very similar diffs for SignedIdentityKeysBlob.
keyserver/src/socket/session-utils.js | ||
---|---|---|
136–137 ↗ | (On Diff #26634) | I know this approach was used earlier, but isn't it just tString(serverRequestTypes.INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE)? |
245–248 ↗ | (On Diff #26634) | It would be better if it was verified using tComb validator |
253 ↗ | (On Diff #26634) | What is the meaning of this value? |
256–258 ↗ | (On Diff #26634) | Is it safe to ignore the exception? Would the client ever know that something went wrong? |
keyserver/src/socket/session-utils.js | ||
---|---|---|
136–137 ↗ | (On Diff #26634) | I am not sure if that is what you were thinking about but an attempt to use it in the following way: tShape({ type: t.String(serverRequestTypes.INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE), initialNotificationsEncryptedMessage: t.String, }), results in flow error: Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/socket/session-utils.js:136:13 Cannot call t.String because a call signature declaring the expected parameter / return type is missing in TIrreducible [1]. [prop-missing] src/socket/session-utils.js 133│ signedIdentityKeysBlob: signedIdentityKeysBlobValidator, 134│ }), 135│ tShape({ 136│ type: t.String(serverRequestTypes.INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE), 137│ initialNotificationsEncryptedMessage: t.String, 138│ }), 139│ ]); ../lib/flow-typed/npm/tcomb_v3.x.x.js [1] 110│ +String: TIrreducible<string>, Found 1 error |
253 ↗ | (On Diff #26634) | The keyserver has to olm accounts: one for notifications and the other for communication with identity service. createOlmSession can be used to create session for both of this accounts. This argument informs which olm account we will use to create olm session. In this particular case we will use olm accounts for e2e notifications. |
256–258 ↗ | (On Diff #26634) | I think it si for three reasones:
Until the linear issue mentioned above is not resolved we don't really have a proper way to handle such failure on the client. |