[web] Change border radius of filled-in input fields
ClosedPublic
Actions

Authored by inka on May 24 2023, 4:22 AM.

Details

Reviewers

• kuba
michal
ginsu

Commits

rCOMM0df0241c3258: [web] Change border radius of filled-in input fields

Summary

issue: https://linear.app/comm/issue/ENG-3866/update-web-filled-in-input-fields
We want all filled in input fields to have a border radius of 8.

Test Plan

Checked that the radius of search input fields and the input bar is now 8px.
I went through all places in the code where border radius is specified and checked what they relate to. I went through the app and checked for any filled-in input fields.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 24 2023, 4:22 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 24 2023, 4:22 AM

Harbormaster completed remote builds in B19720: Diff 26960.May 24 2023, 4:40 AM

inka requested review of this revision.May 24 2023, 4:40 AM

michal accepted this revision.May 25 2023, 2:05 AM

This revision is now accepted and ready to land.May 25 2023, 2:05 AM

Closed by commit rCOMM0df0241c3258: [web] Change border radius of filled-in input fields (authored by • InkaSokolowska). · Explain WhyJun 1 2023, 2:09 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM0df0241c3258: [web] Change border radius of filled-in input fields.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-bar.css

2 lines

components/

search.css

2 lines

Diff 27337

View Options

web/chat/chat-input-bar.css

This file was added.

				// @flow

				import { processReportStoreOperations } from './report-store-ops.js';
				import {
				type ClientReportCreationRequest,
				reportTypes,
				} from '../types/report-types.js';

				const defaultReport = {
				type: reportTypes.MEDIA_MISSION,
				time: Date.now(),
				mediaMission: {
				steps: [],
				result: { success: true },
				totalTime: 0,
				userTime: 0,
				},
				};

				const defaultMockReportWeb = {
				platformDetails: { platform: 'web' },
				...defaultReport,
				};

				const defaultMockReportIos = {
				platformDetails: { platform: 'ios' },
				...defaultReport,
				};

				const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportWeb,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];

				const sortReports = (
				queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
				): $ReadOnlyArray<ClientReportCreationRequest> => {
				return [...queuedReports].sort(
				(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
				a.id.localeCompare(b.id),
				);
				};

				describe('processReportStoreOperations', () => {
				it('should return the original reports if no operations are processed', () => {
				const reportStoreOps = [];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(mockReports);
				});

				it('should replace the report with the given id', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportIos,
				id: '2',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				{
				...defaultMockReportIos,
				id: '2',
				},
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);

				expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
				});

				it('should handle an empty reports with replace operation', () => {
				const reportStoreOps = [
				{
				type: 'replace_report',
				payload: {
				report: {
				...defaultMockReportWeb,
				id: '1',
				},
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '1',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should remove reports with given ids', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];
				const expectedReports = [
				{
				...defaultMockReportWeb,
				id: '3',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual(expectedReports);
				});

				it('should handle empty reports with remove_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_reports',
				payload: {
				ids: ['1', '2'],
				},
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});

				it('should remove all reports', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];
				const processedReports = processReportStoreOperations(
				mockReports,
				reportStoreOps,
				);
				expect(processedReports).toEqual([]);
				});

				it('should handle empty reports with remove_all_reports operation', () => {
				const reportStoreOps = [
				{
				type: 'remove_all_reports',
				},
				];

				const processedReports = processReportStoreOperations([], reportStoreOps);
				expect(processedReports).toEqual([]);
				});
				});