Page MenuHomePhabricator
Differential D7954

[web] Change border radius of filled-in input fields
ClosedPublic
Actions

Authored by inka on May 24 2023, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 5:44 PM
Unknown Object (File)
Tue, Mar 11, 9:31 AM
Unknown Object (File)
Sat, Mar 8, 1:00 AM
Unknown Object (File)
Mon, Mar 3, 8:53 PM
Unknown Object (File)
Sat, Mar 1, 11:31 PM
Unknown Object (File)
Sat, Mar 1, 11:31 PM
Unknown Object (File)
Sat, Mar 1, 11:31 PM
Unknown Object (File)
Sat, Mar 1, 11:24 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• kuba
michal
ginsu
Commits
rCOMM0df0241c3258: [web] Change border radius of filled-in input fields
Summary

issue: https://linear.app/comm/issue/ENG-3866/update-web-filled-in-input-fields
We want all filled in input fields to have a border radius of 8.

Test Plan

Checked that the radius of search input fields and the input bar is now 8px.
I went through all places in the code where border radius is specified and checked what they relate to. I went through the app and checked for any filled-in input fields.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines
components/
2 lines

Diff 27337

View Options

web/chat/chat-input-bar.css

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { FlatList, Platform } from 'react-native'; import { FlatList, Platform } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context'; import { SafeAreaView } from 'react-native-safe-area-context';
import { useSelector } from 'react-redux'; import { useSelector } from 'react-redux';
import { import {
childThreadInfos, childThreadInfos,
communityThreadSelector, communityThreadSelector,
} from 'lib/selectors/thread-selectors'; } from 'lib/selectors/thread-selectors';
import { threadIsChannel } from 'lib/shared/thread-utils'; import {
import { type ThreadInfo, communitySubthreads } from 'lib/types/thread-types'; createRecursiveDrawerItemsData,
appendSuffix,
} from 'lib/utils/drawer-utils.react';
import { useNavigateToThread } from '../chat/message-list-types'; import { useNavigateToThread } from '../chat/message-list-types';
import { useStyles } from '../themes/colors'; import { useStyles } from '../themes/colors';
import type { TextStyle } from '../types/styles';
import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react'; import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react';
const maxDepth = 2; const maxDepth = 2;
const safeAreaEdges = Platform.select({ const safeAreaEdges = Platform.select({
ios: ['top'], ios: ['top'],
default: ['top', 'bottom'], default: ['top', 'bottom'],
}); });
Show All 10 Linesfunction CommunityDrawerContent(): React.Node {
const navigateToThread = useNavigateToThread(); const navigateToThread = useNavigateToThread();
const childThreadInfosMap = useSelector(childThreadInfos); const childThreadInfosMap = useSelector(childThreadInfos);
const setOpenCommunnityOrClose = React.useCallback((index: string) => { const setOpenCommunnityOrClose = React.useCallback((index: string) => {
setOpenCommunity(open => (open === index ? null : index)); setOpenCommunity(open => (open === index ? null : index));
}, []); }, []);
const renderItem = React.useCallback( const renderItem = React.useCallback(
({ item }) => { ({ item }) => {
const itemData = {
threadInfo: item.threadInfo,
itemChildren: item.itemChildren,
labelStyle: item.labelStyle,
hasSubchannelsButton: item.subchannelsButton,
};
return ( return (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
key={item.key} key={item.threadInfo.id}
itemData={itemData} itemData={item}
toggleExpanded={setOpenCommunnityOrClose} toggleExpanded={setOpenCommunnityOrClose}
expanded={itemData.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread} navigateToThread={navigateToThread}
/> />
); );
}, },
michalUnsubmitted
Not Done
Inline Actions
}, []);
const renderItem = React.useCallback(
- ({ item }) => {
- return (
+ ({ item }) => (
<CommunityDrawerItemCommunity
key={item.threadInfo.id}
itemData={item}
toggleExpanded={setOpenCommunnityOrClose}
expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread}
/>
- );
- },
+ ),
[navigateToThread, openCommunity, setOpenCommunnityOrClose],

This now can be simplified.

michal: This now can be simplified.
[navigateToThread, openCommunity, setOpenCommunnityOrClose], [navigateToThread, openCommunity, setOpenCommunnityOrClose],
); );
const labelStylesObj = useStyles(labelUnboundStyles); const labelStylesObj = useStyles(labelUnboundStyles);
const labelStyles = React.useMemo( const labelStyles = React.useMemo(
() => [ () => [
labelStylesObj.level0Label, labelStylesObj.level0Label,
labelStylesObj.level1Label, labelStylesObj.level1Label,
labelStylesObj.level2Label, labelStylesObj.level2Label,
], ],
[labelStylesObj], [labelStylesObj],
); );
const drawerItemsData = React.useMemo( const drawerItemsData = React.useMemo(
() => () =>
createRecursiveDrawerItemsData( createRecursiveDrawerItemsData(
childThreadInfosMap, childThreadInfosMap,
communitiesSuffixed, communitiesSuffixed,
labelStyles, labelStyles,
maxDepth,
), ),
[childThreadInfosMap, communitiesSuffixed, labelStyles], [childThreadInfosMap, communitiesSuffixed, labelStyles],
); );
return ( return (
<SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}> <SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}>
<FlatList data={drawerItemsData} renderItem={renderItem} /> <FlatList data={drawerItemsData} renderItem={renderItem} />
</SafeAreaView> </SafeAreaView>
); );
} }
function createRecursiveDrawerItemsData(
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
communities: $ReadOnlyArray<ThreadInfo>,
labelStyles: $ReadOnlyArray<TextStyle>,
) {
const result = communities.map(community => ({
key: community.id,
threadInfo: community,
itemChildren: [],
labelStyle: labelStyles[0],
subchannelsButton: false,
}));
let queue = result.map(item => [item, 0]);
for (let i = 0; i < queue.length; i++) {
const [item, lvl] = queue[i];
const itemChildThreadInfos = childThreadInfosMap[item.threadInfo.id] ?? [];
if (lvl < maxDepth) {
item.itemChildren = itemChildThreadInfos
.filter(childItem => communitySubthreads.includes(childItem.type))
.map(childItem => ({
threadInfo: childItem,
itemChildren: [],
labelStyle: labelStyles[Math.min(lvl + 1, labelStyles.length - 1)],
hasSubchannelsButton:
lvl + 1 === maxDepth &&
threadHasSubchannels(childItem, childThreadInfosMap),
}));
queue = queue.concat(
item.itemChildren.map(childItem => [childItem, lvl + 1]),
);
}
}
return result;
}
function threadHasSubchannels(
threadInfo: ThreadInfo,
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
) {
if (!childThreadInfosMap[threadInfo.id]?.length) {
return false;
}
return childThreadInfosMap[threadInfo.id].some(thread =>
threadIsChannel(thread),
);
}
function appendSuffix(chats: $ReadOnlyArray<ThreadInfo>): ThreadInfo[] {
const result = [];
const names = new Map<string, number>();
for (const chat of chats) {
let name = chat.uiName;
const numberOfOccurrences = names.get(name);
names.set(name, (numberOfOccurrences ?? 0) + 1);
if (numberOfOccurrences) {
name = `${name} (${numberOfOccurrences.toString()})`;
}
result.push({ ...chat, uiName: name });
}
return result;
}
const unboundStyles = { const unboundStyles = {
drawerContent: { drawerContent: {
flex: 1, flex: 1,
paddingRight: 8, paddingRight: 8,
paddingTop: 8, paddingTop: 8,
backgroundColor: 'drawerBackgroud', backgroundColor: 'drawerBackgroud',
}, },
}; };
Show All 26 Lines
View Options

web/components/search.css

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { FlatList, Platform } from 'react-native'; import { FlatList, Platform } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context'; import { SafeAreaView } from 'react-native-safe-area-context';
import { useSelector } from 'react-redux'; import { useSelector } from 'react-redux';
import { import {
childThreadInfos, childThreadInfos,
communityThreadSelector, communityThreadSelector,
} from 'lib/selectors/thread-selectors'; } from 'lib/selectors/thread-selectors';
import { threadIsChannel } from 'lib/shared/thread-utils'; import {
import { type ThreadInfo, communitySubthreads } from 'lib/types/thread-types'; createRecursiveDrawerItemsData,
appendSuffix,
} from 'lib/utils/drawer-utils.react';
import { useNavigateToThread } from '../chat/message-list-types'; import { useNavigateToThread } from '../chat/message-list-types';
import { useStyles } from '../themes/colors'; import { useStyles } from '../themes/colors';
import type { TextStyle } from '../types/styles';
import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react'; import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react';
const maxDepth = 2; const maxDepth = 2;
const safeAreaEdges = Platform.select({ const safeAreaEdges = Platform.select({
ios: ['top'], ios: ['top'],
default: ['top', 'bottom'], default: ['top', 'bottom'],
}); });
Show All 10 Linesfunction CommunityDrawerContent(): React.Node {
const navigateToThread = useNavigateToThread(); const navigateToThread = useNavigateToThread();
const childThreadInfosMap = useSelector(childThreadInfos); const childThreadInfosMap = useSelector(childThreadInfos);
const setOpenCommunnityOrClose = React.useCallback((index: string) => { const setOpenCommunnityOrClose = React.useCallback((index: string) => {
setOpenCommunity(open => (open === index ? null : index)); setOpenCommunity(open => (open === index ? null : index));
}, []); }, []);
const renderItem = React.useCallback( const renderItem = React.useCallback(
({ item }) => { ({ item }) => {
const itemData = {
threadInfo: item.threadInfo,
itemChildren: item.itemChildren,
labelStyle: item.labelStyle,
hasSubchannelsButton: item.subchannelsButton,
};
return ( return (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
key={item.key} key={item.threadInfo.id}
itemData={itemData} itemData={item}
toggleExpanded={setOpenCommunnityOrClose} toggleExpanded={setOpenCommunnityOrClose}
expanded={itemData.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread} navigateToThread={navigateToThread}
/> />
); );
}, },
michalUnsubmitted
Not Done
Inline Actions
}, []);
const renderItem = React.useCallback(
- ({ item }) => {
- return (
+ ({ item }) => (
<CommunityDrawerItemCommunity
key={item.threadInfo.id}
itemData={item}
toggleExpanded={setOpenCommunnityOrClose}
expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread}
/>
- );
- },
+ ),
[navigateToThread, openCommunity, setOpenCommunnityOrClose],

This now can be simplified.

michal: This now can be simplified.
[navigateToThread, openCommunity, setOpenCommunnityOrClose], [navigateToThread, openCommunity, setOpenCommunnityOrClose],
); );
const labelStylesObj = useStyles(labelUnboundStyles); const labelStylesObj = useStyles(labelUnboundStyles);
const labelStyles = React.useMemo( const labelStyles = React.useMemo(
() => [ () => [
labelStylesObj.level0Label, labelStylesObj.level0Label,
labelStylesObj.level1Label, labelStylesObj.level1Label,
labelStylesObj.level2Label, labelStylesObj.level2Label,
], ],
[labelStylesObj], [labelStylesObj],
); );
const drawerItemsData = React.useMemo( const drawerItemsData = React.useMemo(
() => () =>
createRecursiveDrawerItemsData( createRecursiveDrawerItemsData(
childThreadInfosMap, childThreadInfosMap,
communitiesSuffixed, communitiesSuffixed,
labelStyles, labelStyles,
maxDepth,
), ),
[childThreadInfosMap, communitiesSuffixed, labelStyles], [childThreadInfosMap, communitiesSuffixed, labelStyles],
); );
return ( return (
<SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}> <SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}>
<FlatList data={drawerItemsData} renderItem={renderItem} /> <FlatList data={drawerItemsData} renderItem={renderItem} />
</SafeAreaView> </SafeAreaView>
); );
} }
function createRecursiveDrawerItemsData(
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
communities: $ReadOnlyArray<ThreadInfo>,
labelStyles: $ReadOnlyArray<TextStyle>,
) {
const result = communities.map(community => ({
key: community.id,
threadInfo: community,
itemChildren: [],
labelStyle: labelStyles[0],
subchannelsButton: false,
}));
let queue = result.map(item => [item, 0]);
for (let i = 0; i < queue.length; i++) {
const [item, lvl] = queue[i];
const itemChildThreadInfos = childThreadInfosMap[item.threadInfo.id] ?? [];
if (lvl < maxDepth) {
item.itemChildren = itemChildThreadInfos
.filter(childItem => communitySubthreads.includes(childItem.type))
.map(childItem => ({
threadInfo: childItem,
itemChildren: [],
labelStyle: labelStyles[Math.min(lvl + 1, labelStyles.length - 1)],
hasSubchannelsButton:
lvl + 1 === maxDepth &&
threadHasSubchannels(childItem, childThreadInfosMap),
}));
queue = queue.concat(
item.itemChildren.map(childItem => [childItem, lvl + 1]),
);
}
}
return result;
}
function threadHasSubchannels(
threadInfo: ThreadInfo,
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
) {
if (!childThreadInfosMap[threadInfo.id]?.length) {
return false;
}
return childThreadInfosMap[threadInfo.id].some(thread =>
threadIsChannel(thread),
);
}
function appendSuffix(chats: $ReadOnlyArray<ThreadInfo>): ThreadInfo[] {
const result = [];
const names = new Map<string, number>();
for (const chat of chats) {
let name = chat.uiName;
const numberOfOccurrences = names.get(name);
names.set(name, (numberOfOccurrences ?? 0) + 1);
if (numberOfOccurrences) {
name = `${name} (${numberOfOccurrences.toString()})`;
}
result.push({ ...chat, uiName: name });
}
return result;
}
const unboundStyles = { const unboundStyles = {
drawerContent: { drawerContent: {
flex: 1, flex: 1,
paddingRight: 8, paddingRight: 8,
paddingTop: 8, paddingTop: 8,
backgroundColor: 'drawerBackgroud', backgroundColor: 'drawerBackgroud',
}, },
}; };
Show All 26 Lines