Page MenuHomePhabricator
Differential D7980

[native] Display error message when community creation fails
ClosedPublic
Actions

Authored by atul on May 25 2023, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 3:23 AM
Unknown Object (File)
Thu, Apr 4, 9:33 PM
Unknown Object (File)
Thu, Apr 4, 9:33 PM
Unknown Object (File)
Thu, Apr 4, 9:33 PM
Unknown Object (File)
Thu, Apr 4, 9:29 PM
Unknown Object (File)
Sun, Mar 31, 7:13 AM
Unknown Object (File)
Fri, Mar 29, 8:41 AM
Unknown Object (File)
Mar 4 2024, 2:57 AM
View All 43 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMc395aab3ca94: [native] Display error message when community creation fails
Summary

We display an error message below the "Create Community" button when the community creation request fails.

We clear the error message when

  1. User changes name input
  2. User changes announcement setting
  3. User re-attempts community creation

Depends on D7979

Test Plan

Looks as expected (killed keyserver to ensure requests failed):

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-25 at 12.54.32.png (2×1 px, 154 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 25 2023, 9:53 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 25 2023, 9:53 AM
atul published this revision for review.May 25 2023, 9:54 AM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
native/community-creation/community-configuration.react.js
274–279 ↗(On Diff #27065)

Styling here was to match what we currently have in the app. Made a note in Linear that we should consistently display error states/messages: https://linear.app/comm/issue/DES-89/ensure-consistent-forminput-styling-throughout-designs#comment-0dd7aa2f

Harbormaster completed remote builds in B19773: Diff 27065.May 25 2023, 10:11 AM
atul added a child revision: D7987: [native] Introduce placeholder `CommunityCreationMembers` component.May 25 2023, 11:15 AM
ashoat accepted this revision.May 26 2023, 10:26 AM
This revision is now accepted and ready to land.May 26 2023, 10:26 AM
Closed by commit rCOMMc395aab3ca94: [native] Display error message when community creation fails (authored by atul). · Explain WhyMay 26 2023, 10:34 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc395aab3ca94: [native] Display error message when community creation fails.

Revision Contents
Changeset List

PathSize
native/
community-creation/
40 lines

Diff 27098

View Options

native/community-creation/community-configuration.react.js

Loading...