Page MenuHomePhabricator

[native] Display error message when community creation fails
ClosedPublic

Authored by atul on May 25 2023, 9:53 AM.
Tags
None
Referenced Files
F1789910: D7980.diff
Sun, May 19, 6:59 AM
Unknown Object (File)
Tue, May 7, 12:13 PM
Unknown Object (File)
Mon, May 6, 12:08 PM
Unknown Object (File)
Sun, Apr 28, 6:32 PM
Unknown Object (File)
Wed, Apr 24, 3:23 AM
Unknown Object (File)
Apr 4 2024, 9:33 PM
Unknown Object (File)
Apr 4 2024, 9:33 PM
Unknown Object (File)
Apr 4 2024, 9:33 PM
Subscribers

Details

Summary

We display an error message below the "Create Community" button when the community creation request fails.

We clear the error message when

  1. User changes name input
  2. User changes announcement setting
  3. User re-attempts community creation

Depends on D7979

Test Plan

Looks as expected (killed keyserver to ensure requests failed):

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-25 at 12.54.32.png (2×1 px, 154 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.May 25 2023, 9:54 AM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
native/community-creation/community-configuration.react.js
274–279 ↗(On Diff #27065)

Styling here was to match what we currently have in the app. Made a note in Linear that we should consistently display error states/messages: https://linear.app/comm/issue/DES-89/ensure-consistent-forminput-styling-throughout-designs#comment-0dd7aa2f

This revision is now accepted and ready to land.May 26 2023, 10:26 AM