Paths

Table of Contentst

-
native/community-creation/
-
community-creation/
1/2
community-configuration.react.js

[native] Display error message when community creation fails
ClosedPublic
Actions

Authored by atul on May 25 2023, 9:53 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMc395aab3ca94: [native] Display error message when community creation fails

Summary

We display an error message below the "Create Community" button when the community creation request fails.

We clear the error message when

User changes name input
User changes announcement setting
User re-attempts community creation

Depends on D7979

Test Plan

Looks as expected (killed keyserver to ensure requests failed):

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-25 at 12.54.32.png (2×1 px, 154 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 25 2023, 9:53 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 25 2023, 9:53 AM

atul published this revision for review.May 25 2023, 9:54 AM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

native/community-creation/community-configuration.react.js
274–279	Styling here was to match what we currently have in the app. Made a note in Linear that we should consistently display error states/messages: https://linear.app/comm/issue/DES-89/ensure-consistent-forminput-styling-throughout-designs#comment-0dd7aa2f

Harbormaster completed remote builds in B19773: Diff 27065.May 25 2023, 10:11 AM

atul added a child revision: D7987: [native] Introduce placeholder `CommunityCreationMembers` component.May 25 2023, 11:15 AM

ashoat accepted this revision.May 26 2023, 10:26 AM

This revision is now accepted and ready to land.May 26 2023, 10:26 AM

Closed by commit rCOMMc395aab3ca94: [native] Display error message when community creation fails (authored by atul). · Explain WhyMay 26 2023, 10:34 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc395aab3ca94: [native] Display error message when community creation fails.

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

40 lines

Diff 27065

View Options

native/community-creation/community-configuration.react.js

use derive_more::{Display, Error, From};		use derive_more::{Display, Error, From};
use futures_core::Stream;		use futures_core::Stream;
use futures_util::StreamExt;		use futures_util::{StreamExt, TryStreamExt};
use reqwest::Url;		use reqwest::{
		multipart::{Form, Part},
		Body, Url,
		};
use tracing::{debug, trace, warn};		use tracing::{debug, trace, warn};

// publicly re-export some reqwest types		// publicly re-export some reqwest types
pub use reqwest::Error as ReqwestError;		pub use reqwest::Error as ReqwestError;
pub use reqwest::StatusCode;		pub use reqwest::StatusCode;

#[derive(From, Error, Debug, Display)]		#[derive(From, Error, Debug, Display)]
pub enum BlobServiceError {		pub enum BlobServiceError {
▲ Show 20 Lines • Show All 91 Lines • ▼ Show 20 Lines	) -> BlobResult<impl Stream<Item = BlobResult<Vec<u8>>>> {
}		}

let error = handle_http_error(response.status());		let error = handle_http_error(response.status());
if let Ok(message) = response.text().await {		if let Ok(message) = response.text().await {
trace!("Error response message: {}", message);		trace!("Error response message: {}", message);
}		}
Err(error)		Err(error)
}		}

		/// Uploads a blob. Returns `BlobServiceError::AlreadyExists` if blob with given hash
		/// already exists.
		///
		/// # Example
		/// ```rust
		/// use std::io::{Error, ErrorKind};
		///
		/// let client =
		/// BlobServiceClient::new("http://localhost:50053".parse()?);
		///
		/// let stream = async_stream::stream! {
		/// yield Ok(vec![1, 2, 3]);
		/// yield Ok(vec![4, 5, 6]);
		/// yield Err(Error::new(ErrorKind::Other, "Oops"));
		/// };
		/// client.upload_blob(&blob_hash, stream).await?;
		/// ```
		pub async fn upload_blob<H, S>(
		&self,
		blob_hash: H,
		data_stream: S,
		) -> BlobResult<()>
		where
		H: Into<String>,
		S: futures_core::stream::TryStream + Send + Sync + 'static,
		S::Error: Into<Box<dyn std::error::Error + Send + Sync>>,
		Vec<u8>: From<S::Ok>,
		bartekAuthorUnsubmitted Done Inline Actions Requirements of the reqwest body stream: A stream of `Result<impl Into<Vec<u8>>, impl Into<Box<dyn Error>>>` bartek: Requirements of the reqwest body stream: A stream of `Result<impl Into<Vec<u8>>, impl…
		{
		debug!("Revoke holder request");
		michalUnsubmitted Not Done Inline Actions Wrong message? michal: Wrong message?
		let url = self.get_blob_url(None)?;

		let stream = data_stream.map_ok(Vec::from);
		let streaming_body = Body::wrap_stream(stream);
		let form = Form::new()
		.text("blob_hash", blob_hash.into())
		.part("blob_data", Part::stream(streaming_body));

		let response = self.http_client.put(url).multipart(form).send().await?;
		debug!("Response status: {}", response.status());

		if response.status().is_success() {
		trace!("Blob upload successful");
		return Ok(());
		}

		let error = handle_http_error(response.status());
		if let Ok(message) = response.text().await {
		trace!("Error response message: {}", message);
		}
		Err(error)
		}
}		}

// private helper methods		// private helper methods
impl BlobServiceClient {		impl BlobServiceClient {
fn get_blob_url(		fn get_blob_url(
&self,		&self,
blob_hash: Option<&str>,		blob_hash: Option<&str>,
) -> Result<Url, BlobServiceError> {		) -> Result<Url, BlobServiceError> {
Show All 24 Lines

[native] Display error message when community creation failsClosedPublicActions