Page MenuHomePhabricator

[native] Minor updates to KeyserverSelection TextInput
ClosedPublic

Authored by ashoat on Thu, May 25, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 1, 6:24 PM
F559126: Screenshot 2023-05-25 at 3.04.12 PM.png
Thu, May 25, 12:12 PM
F559121: Screenshot 2023-05-25 at 3.03.49 PM.png
Thu, May 25, 12:12 PM
Subscribers

Details

Summary

While working on the TextInputs for UsernameSelection and PasswordSelection, I realized a couple updates I should make to the TextInput in KeyserverSelection:

  1. Set onSubmitEditing, so that the user can use the software keyboard action button to proceed to the next screen.
  2. Use returnKeyType="go" instead of the default "next". The latter matches the copy of our RegistrationButton, but is treated by the OS as more of a "next input field" button. Whereas "go" is meant for "I'm done with this page, go to the next one" and utilizes a design that indicates a more explicit action.
Test Plan
  1. I tested onSubmitEditing by pressing the button while the TextInput was empty (nothing happens, same as before) and while the TextInput was populated (proceeds to the next screen).
  2. Here are screenshots for the returnKeyType change:
beforeafter
Screenshot 2023-05-25 at 3.03.49 PM.png (2×1 px, 929 KB)
Screenshot 2023-05-25 at 3.04.12 PM.png (2×1 px, 928 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/account/registration/keyserver-selection.react.js
69–71 ↗(On Diff #27075)

This change was necessary since onSubmit can now be called by the software keyboard, which doesn't get disabled when keyserverUsername is falsey

This revision is now accepted and ready to land.Thu, May 25, 1:59 PM