Page MenuHomePhabricator

[native] Implement PasswordSelection logic
ClosedPublic

Authored by ashoat on May 25 2023, 12:27 PM.
Tags
None
Referenced Files
F1864970: D7992.id27082.diff
Sun, May 26, 9:02 AM
F1864968: D7992.id27079.diff
Sun, May 26, 9:02 AM
F1864967: D7992.id27078.diff
Sun, May 26, 9:02 AM
F1864778: D7992.diff
Sun, May 26, 8:50 AM
F1863541: D7992.id.diff
Sun, May 26, 6:09 AM
Unknown Object (File)
Wed, May 15, 6:07 AM
Unknown Object (File)
Wed, May 8, 12:33 PM
Unknown Object (File)
Apr 23 2024, 2:27 PM
Subscribers

Details

Summary

See designs here.

Depends on D7990

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul added inline comments.
native/account/registration/password-selection.react.js
44 ↗(On Diff #27078)

super minor nit: newline after this callback might help readability a bit

This revision is now accepted and ready to land.May 25 2023, 2:01 PM

Newline and textContentType="newPassword"

Regarding the latter, see here:

For iOS 12+ newPassword can be used to indicate a new password input the user may want to save in the keychain

Our Podfile locks us to iOS 13+.

This revision was landed with ongoing or failed builds.May 25 2023, 2:10 PM
This revision was automatically updated to reflect the committed changes.