Page MenuHomePhabricator

[native] Implement PasswordSelection logic
ClosedPublic

Authored by ashoat on May 25 2023, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 7:11 AM
Unknown Object (File)
Wed, Jun 12, 9:01 AM
Unknown Object (File)
Mon, Jun 10, 7:22 PM
Unknown Object (File)
Sun, May 26, 9:02 AM
Unknown Object (File)
Sun, May 26, 9:02 AM
Unknown Object (File)
Sun, May 26, 9:02 AM
Unknown Object (File)
Sun, May 26, 8:50 AM
Unknown Object (File)
Sun, May 26, 6:09 AM
Subscribers

Details

Summary

See designs here.

Depends on D7990

Test Plan

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added inline comments.
native/account/registration/password-selection.react.js
44

super minor nit: newline after this callback might help readability a bit

This revision is now accepted and ready to land.May 25 2023, 2:01 PM

Newline and textContentType="newPassword"

Regarding the latter, see here:

For iOS 12+ newPassword can be used to indicate a new password input the user may want to save in the keychain

Our Podfile locks us to iOS 13+.

This revision was landed with ongoing or failed builds.May 25 2023, 2:10 PM
This revision was automatically updated to reflect the committed changes.