Page MenuHomePhabricator
Differential D7992

[native] Implement PasswordSelection logic
ClosedPublic
Actions

Authored by ashoat on May 25 2023, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Wed, Nov 6, 3:44 PM
Unknown Object (File)
Tue, Nov 5, 9:10 AM
Unknown Object (File)
Nov 1 2024, 9:46 AM
Unknown Object (File)
Nov 1 2024, 9:46 AM
Unknown Object (File)
Nov 1 2024, 9:46 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMb2cc8cdbd7ee: [native] Implement PasswordSelection logic
Summary

See designs here.

Depends on D7990

Test Plan

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 25 2023, 12:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 25 2023, 12:27 PM
ashoat edited the test plan for this revision. (Show Details)May 25 2023, 12:29 PM
Harbormaster completed remote builds in B19785: Diff 27078.May 25 2023, 12:48 PM
ashoat requested review of this revision.May 25 2023, 12:48 PM
atul accepted this revision.May 25 2023, 2:01 PM
atul added inline comments.
native/account/registration/password-selection.react.js
44

super minor nit: newline after this callback might help readability a bit

This revision is now accepted and ready to land.May 25 2023, 2:01 PM
ashoat updated this revision to Diff 27079.May 25 2023, 2:03 PM

Newline and textContentType="newPassword"

Regarding the latter, see here:

For iOS 12+ newPassword can be used to indicate a new password input the user may want to save in the keychain

Our Podfile locks us to iOS 13+.

This revision was landed with ongoing or failed builds.May 25 2023, 2:10 PM
Closed by commit rCOMMb2cc8cdbd7ee: [native] Implement PasswordSelection logic (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb2cc8cdbd7ee: [native] Implement PasswordSelection logic.
Harbormaster completed remote builds in B19786: Diff 27079.May 25 2023, 2:24 PM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
89 lines

Diff 27078

View Options

native/account/registration/password-selection.react.js

Loading...