Page MenuHomePhabricator

[native] Minor updates to UsernameSelection

Authored by ashoat on May 25 2023, 12:12 PM.
Referenced Files
Sun, May 26, 2:05 PM
F1866708: D7990.diff
Sun, May 26, 2:05 PM
F1864772: D7990.id27076.diff
Sun, May 26, 8:50 AM
Unknown Object (File)
Sat, May 25, 5:38 PM
Unknown Object (File)
Sun, May 19, 11:10 AM
Unknown Object (File)
Tue, May 14, 3:13 PM
Unknown Object (File)
Tue, May 7, 11:11 AM
Unknown Object (File)
Wed, May 1, 2:22 PM



Two things I noticed while working on PasswordSelection:

  1. The same returnKeyType="go" change that I included in the previous diff (D7989).
  2. When checkUsernameValidity is called, if the username is valid we will now clear the usernameError.

Depends on D7989

Test Plan
  1. For returnKeyType="go", I confirmed the button was changed. For a visual indication of the change, check the previous diff.
  2. For the checkUsernameValidity change, I triggered a username error by typing in an invalid username (eg. starting with a - character). Then I focused the keyboard, fixed the error, and then dismissed the keyboard. I confirmed that the error text disappeared after the dismissal.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

54 ↗(On Diff #27076)

I flipped the order of the conditions since they now had the same amount of code, and I figured it made more sense to have the "default" condition at end, in part for consistency with PasswordSelection which has two possible error states

This revision is now accepted and ready to land.May 25 2023, 2:00 PM