Details
Details
- Reviewers
atul ginsu - Commits
- rCOMM1192076525b1: [native] Minor updates to UsernameSelection
- For returnKeyType="go", I confirmed the button was changed. For a visual indication of the change, check the previous diff.
- For the checkUsernameValidity change, I triggered a username error by typing in an invalid username (eg. starting with a - character). Then I focused the keyboard, fixed the error, and then dismissed the keyboard. I confirmed that the error text disappeared after the dismissal.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/registration
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/account/registration/username-selection.react.js | ||
---|---|---|
54 | I flipped the order of the conditions since they now had the same amount of code, and I figured it made more sense to have the "default" condition at end, in part for consistency with PasswordSelection which has two possible error states |