Page MenuHomePhabricator

[native] Minor updates to KeyserverSelection TextInput

Authored by ashoat on May 25 2023, 12:07 PM.
Referenced Files
Unknown Object (File)
Thu, Aug 31, 8:39 PM
Unknown Object (File)
Thu, Aug 24, 10:26 PM
Unknown Object (File)
Aug 23 2023, 8:52 PM
Unknown Object (File)
Aug 23 2023, 8:50 PM
Unknown Object (File)
Aug 23 2023, 8:50 PM
Unknown Object (File)
Jun 29 2023, 8:53 PM
Unknown Object (File)
Jun 29 2023, 6:53 AM
Unknown Object (File)
Jun 28 2023, 6:45 PM



While working on the TextInputs for UsernameSelection and PasswordSelection, I realized a couple updates I should make to the TextInput in KeyserverSelection:

  1. Set onSubmitEditing, so that the user can use the software keyboard action button to proceed to the next screen.
  2. Use returnKeyType="go" instead of the default "next". The latter matches the copy of our RegistrationButton, but is treated by the OS as more of a "next input field" button. Whereas "go" is meant for "I'm done with this page, go to the next one" and utilizes a design that indicates a more explicit action.
Test Plan
  1. I tested onSubmitEditing by pressing the button while the TextInput was empty (nothing happens, same as before) and while the TextInput was populated (proceeds to the next screen).
  2. Here are screenshots for the returnKeyType change:
Screenshot 2023-05-25 at 3.03.49 PM.png (2×1 px, 929 KB)
Screenshot 2023-05-25 at 3.04.12 PM.png (2×1 px, 928 KB)

Diff Detail

rCOMM Comm
No Lint Coverage
No Test Coverage

Event Timeline


This change was necessary since onSubmit can now be called by the software keyboard, which doesn't get disabled when keyserverUsername is falsey

This revision is now accepted and ready to land.May 25 2023, 1:59 PM