[web] Fix thread gallery for encrypted media
ClosedPublic
Actions

Authored by bartek on May 26 2023, 1:19 AM.

Details

Reviewers

inka
ginsu
atul
• kuba

Commits

rCOMM54645791eab3: [web] Fix thread gallery for encrypted media

Summary

This diff fixes ENG-3946.
Added proper source mapping depending on media type and replaced <img> with GalleryItem component added in D7994.

Also fixed filtering condition for encrypted media.

Depends on D7994

Test Plan

Open media gallery for encrypted and non-encrypted media. Check that all images are displayed properly. Throttle network, then check thumbhashes are displayed while images are loading.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 26 2023, 1:19 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 26 2023, 1:19 AM

bartek added a child revision: D7996: [web] Simplify media gallery hooks.May 26 2023, 1:26 AM

Harbormaster completed remote builds in B19789: Diff 27085.May 26 2023, 1:37 AM

bartek published this revision for review.May 26 2023, 1:52 AM

atul accepted this revision.May 26 2023, 9:00 AM

This revision is now accepted and ready to land.May 26 2023, 9:00 AM

Closed by commit rCOMM54645791eab3: [web] Fix thread gallery for encrypted media (authored by bartek). · Explain WhyMay 30 2023, 11:46 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM54645791eab3: [web] Fix thread gallery for encrypted media.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

gallery/

thread-settings-media-gallery.react.js

52 lines

Diff 27290

View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

[web] Fix thread gallery for encrypted mediaClosedPublicActions