Page MenuHomePhabricator
Differential D8020

[native] Replace removeThreadAvatar with generic setThreadAvatar
ClosedPublic
Actions

Authored by ashoat on May 29 2023, 5:39 PM.
Tags
None
Referenced Files
F3404587: D8020.diff
Tue, Dec 3, 11:51 AM
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Unknown Object (File)
Oct 15 2024, 9:16 PM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
View All 85 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar
Summary

Decided to do the same thing for thread avatars here as I did for user avatars in D8017. It's good to unify codepaths, and this diff will allow me to deprecate useSaveThreadAvatar in the next diff, replacing it with the shared utilities in EditThreadAvatarProvider.

Depends on D8019

Test Plan

Test clearing thread avatar via iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 29 2023, 5:39 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 29 2023, 5:39 PM
ashoat added a child revision: D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.May 29 2023, 5:40 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 29 2023, 5:54 PM
Harbormaster failed remote builds in B19880: Diff 27236!
ashoat updated this revision to Diff 27240.May 29 2023, 5:57 PM

Prettier

Harbormaster completed remote builds in B19884: Diff 27240.May 29 2023, 6:15 PM
ashoat requested review of this revision.May 29 2023, 6:15 PM
ashoat updated this revision to Diff 27262.May 30 2023, 5:52 AM

Make setThreadAvatar return Promise<void> for consistency with D8017, since nothing needs its return anyways

Harbormaster completed remote builds in B19901: Diff 27262.May 30 2023, 6:10 AM
atul accepted this revision.May 30 2023, 9:27 AM
This revision is now accepted and ready to land.May 30 2023, 9:27 AM
Closed by commit rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar (authored by ashoat). · Explain WhyMay 30 2023, 12:09 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar.

Revision Contents
Changeset List

Diff 27240

View Options

native/avatars/edit-thread-avatar-provider.react.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...