[native] Introduce new EmojiAvatarSelection screen for registration flow
ClosedPublic
Actions

Authored by ashoat on May 31 2023, 1:10 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM5081dfc4cdb9: [native] Introduce new EmojiAvatarSelection screen for registration flow

Summary

For emoji avatar selection, our current pattern in the native app is to show another screen that handles this.

This diff continues that pattern, but introduces a new screen for the registration flow. Luckily we already have the scaffolding for this, as we needed separate screens for EmojiThreadAvatarCreation and EmojiUserAvatarCreation already.

Depends on D8042

Test Plan

This was tested in combination with the rest of the stack. I tested:

ENS flow, both when user has an ENS avatar and when they don't
Setting an emoji avatar
Setting an image avatar via camera
Setting an image avatar via media library
Tested avatar update flow after being logged in to make sure I didn't regress anything

To see the UI in action, check out the video in D8049!

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 31 2023, 1:10 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 31 2023, 1:10 PM

ashoat added a child revision: D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.May 31 2023, 1:11 PM

ashoat edited the test plan for this revision. (Show Details)May 31 2023, 1:22 PM

ashoat added inline comments.May 31 2023, 1:28 PM

native/account/registration/emoji-avatar-selection.react.js
25 ↗	(On Diff #27321)	This screen isn't actually used until D8047. I usually try to include callsites / usages in the same diff, but in this case I think it's more readable to separate it out