Page MenuHomePhabricator

[native] Fix long names intersecting with the search button
ClosedPublic

Authored by inka on Jun 5 2023, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 3:06 PM
Unknown Object (File)
Tue, Dec 10, 10:35 AM
Unknown Object (File)
Sun, Dec 8, 11:52 AM
Unknown Object (File)
Sat, Dec 7, 2:13 AM
Unknown Object (File)
Thu, Dec 5, 4:59 AM
Unknown Object (File)
Nov 7 2024, 6:06 AM
Unknown Object (File)
Nov 1 2024, 5:34 AM
Unknown Object (File)
Nov 1 2024, 3:05 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3925/long-names-intersecting-with-search-button
from documentation (https://reactnavigation.org/docs/3.x/stack-navigator/#headertitlecontainerstyle):

By default, headerTitleContainerStyle is with an absolute position style and offsets both left and right. This may lead to white space or overlap between headerLeft and headerTitle if a customized headerLeft is used. It can be solved by adjusting left and right style in headerTitleContainerStyle and marginHorizontal in headerTitleStyle.

Our problem was with the headerRight, but an analogical solution worked

Test Plan

Simulator Screenshot - iPhone 14 Pro - 2023-06-05 at 09.10.30.png (2×1 px, 252 KB)

When there are no buttons:

Simulator Screenshot - iPhone 14 Pro - 2023-06-05 at 09.07.33.png (2×1 px, 342 KB)

On android long names were always cut pretty short. Before my changes:

Screenshot_20230605_095025.png (2×1 px, 209 KB)

After my changes:

Screenshot_20230605_094533.png (2×1 px, 210 KB)

Diff Detail

Repository
rCOMM Comm
Branch
inka/fix_longnames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jun 5 2023, 1:20 AM
This revision is now accepted and ready to land.Jun 5 2023, 4:07 AM