[blob-service] Use new error types in S3 functions
ClosedPublic
Actions

Authored by bartek on Jun 6 2023, 2:01 AM.

Details

Reviewers

• jon
varun
michal

Commits

rCOMM1f505867d9d4: [blob-service] Use new error types in S3 functions

Summary

Part of ENG-2398 - replaces anyhow with S3-specific error types in database functions.

Depends on D8100

Test Plan

Played with these by providing invalid inputs to S3 SDK functions (e.g. non-existing object or incorrect S3 path) - using format!("Error: {:?}", s3_error) displayed correct error types.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 6 2023, 2:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 2:01 AM

bartek added a child revision: D8102: [blob-service] Use S3 errors in HTTP endpoints.Jun 6 2023, 2:04 AM

Harbormaster completed remote builds in B20032: Diff 27454.Jun 6 2023, 2:17 AM

bartek published this revision for review.Jun 7 2023, 2:32 AM

looks fine to me, but varun should also take a look

services/blob/src/s3.rs
185 ↗	(On Diff #27454)	alternatively, you could implement From for S3Result to have it implicitly convert. Also, not sure if logging should be done at the data layer (here), or by the calling scope. But I guess that's personal preference.