[blob-service] Use S3 errors in HTTP endpoints
ClosedPublic
Actions

Authored by bartek on Jun 6 2023, 2:04 AM.

Details

Reviewers

• jon
varun
michal

Commits

rCOMMdd77f53460a5: [blob-service] Use S3 errors in HTTP endpoints

Summary

Part of ENG-2398 - this diff changes the HTTP endpoints to use new S3 error types.

Depends on D8101

Test Plan

Mocked database functions to always return errors. Checked with postman that HTTP response codes are correct (400 for empty upload, 500 for others) and errors are logged correctly to stdout.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 6 2023, 2:04 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 2:04 AM

Harbormaster completed remote builds in B20033: Diff 27455.Jun 6 2023, 2:20 AM

bartek published this revision for review.Jun 7 2023, 2:32 AM

LGTM, varun should review though

• jon added 1 blocking reviewer(s): varun.Jun 7 2023, 3:06 PM

varun accepted this revision.Jun 8 2023, 6:54 AM

This revision is now accepted and ready to land.Jun 8 2023, 6:54 AM

Closed by commit rCOMMdd77f53460a5: [blob-service] Use S3 errors in HTTP endpoints (authored by bartek). · Explain WhyJun 12 2023, 1:35 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMdd77f53460a5: [blob-service] Use S3 errors in HTTP endpoints.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

context.rs

18 lines

handlers/

blob.rs

55 lines

Diff 27635

View Options

services/blob/src/http/context.rs