Page MenuHomePhabricator
Differential D8125

[web-db] restore database Safari support
ClosedPublic
Actions

Authored by kamil on Jun 6 2023, 10:21 AM.
Tags
None
Referenced Files
F3351839: D8125.diff
Sat, Nov 23, 3:47 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
Unknown Object (File)
Fri, Nov 1, 4:10 AM
Unknown Object (File)
Fri, Nov 1, 3:48 AM
Unknown Object (File)
Fri, Nov 1, 3:48 AM
Unknown Object (File)
Fri, Nov 1, 3:41 AM
Unknown Object (File)
Sat, Oct 26, 5:56 PM
Unknown Object (File)
Thu, Oct 24, 3:17 PM
View All 71 Files
Subscribers
ashoat
Tokens
"Party Time" token, awarded by atul.

Details

Reviewers
michal
tomek
Commits
rCOMM21e3077f7193: [web-db] restore database Safari support
Summary

Safari bugs are fixed in the rest of the stack.
(context)

Depends on D8124

Test Plan

Test everything end-to-end on Safari (clearing content on logout, init on login, draft persistence, etc.)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 6 2023, 10:21 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 10:21 AM
Harbormaster completed remote builds in B20062: Diff 27492.Jun 6 2023, 10:42 AM
kamil published this revision for review.Jun 7 2023, 1:52 AM
tomek accepted this revision.Jun 13 2023, 4:33 AM
tomek added inline comments.
web/database/utils/constants.js
25

Does it include mobile Safari?

This revision is now accepted and ready to land.Jun 13 2023, 4:33 AM
kamil added inline comments.Jun 14 2023, 9:20 AM
web/database/utils/constants.js
25

If you ask about this variable DB_SUPPORTED_BROWSERS - yes.
If you ask about entire logic - no, we always check also for supported OS and exclude mobiles

Closed by commit rCOMM21e3077f7193: [web-db] restore database Safari support (authored by kamil). · Explain WhyJun 14 2023, 10:14 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM21e3077f7193: [web-db] restore database Safari support.
atul awarded a token.Jun 19 2023, 3:23 PM

Revision Contents
Changeset List

PathSize
web/
database/
utils/
1 line

Diff 27492

View Options

web/database/utils/constants.js

Loading...