Paths

Table of Contentst

Differential D8126

[Protos] Update uploadOneTimeKeys to include device info and both sets of keys
ClosedPublic
Actions

Authored by • jon on Jun 6 2023, 5:39 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

varun
bartek
ashoat

Commits

rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys

Summary

To verify the access token, we need the user_id and
device_id.

For one time keys, we need to set both notif and content keys.

Depends on D8094

Test Plan

N/A, more design

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jun 6 2023, 5:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 6 2023, 5:39 PM

• jon added a child revision: D8127: [Identity] Implement upload one time keys endpoint.Jun 6 2023, 5:41 PM

Harbormaster completed remote builds in B20065: Diff 27495.Jun 6 2023, 5:56 PM

• jon requested review of this revision.Jun 6 2023, 5:56 PM

varun accepted this revision.Jun 6 2023, 6:55 PM

This revision is now accepted and ready to land.Jun 6 2023, 6:55 PM

ashoat requested changes to this revision.Jun 7 2023, 7:40 PM

ashoat added inline comments.

shared/protos/identity_client.proto
307 ↗	(On Diff #27495)	In `VerifyUserAccessTokenRequest`, we call this `signingPublicKey`. Elsewhere we refer to it as `deviceIDKey`. Can you make sure we're consistent and use a single name for this throughout the whole proto?

This revision now requires changes to proceed.Jun 7 2023, 7:40 PM

• jon requested review of this revision.Jun 8 2023, 11:57 PM

• jon marked an inline comment as done.

• jon added inline comments.

shared/protos/identity_client.proto
307 ↗	(On Diff #27495)	Created: https://linear.app/comm/issue/ENG-4072

varun accepted this revision.Jun 9 2023, 5:31 AM

ashoat accepted this revision.Jun 9 2023, 2:22 PM

This revision is now accepted and ready to land.Jun 9 2023, 2:22 PM

Closed by commit rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys. · Explain WhyJun 12 2023, 3:04 AM

This revision was automatically updated to reflect the committed changes.

• jon marked an inline comment as done.

• jon added a commit: rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.

Revision Contents
Changeset List

Path

Size

shared/

protos/

identity_client.proto

8 lines

Diff 27631

shared/protos/identity_client.proto

Loading...