Page MenuHomePhabricator
Differential D8126

[Protos] Update uploadOneTimeKeys to include device info and both sets of keys
ClosedPublic
Actions

Authored by • jon on Jun 6 2023, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:44 AM
Unknown Object (File)
Thu, Apr 18, 2:39 AM
Unknown Object (File)
Feb 23 2024, 7:59 PM
Unknown Object (File)
Feb 23 2024, 7:31 PM
Unknown Object (File)
Feb 23 2024, 6:40 PM
Unknown Object (File)
Feb 23 2024, 4:18 PM
View All 18 Files
Subscribers
tomek

Details

Reviewers
varun
bartek
ashoat
Commits
rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys
Summary

To verify the access token, we need the user_id and
device_id.

For one time keys, we need to set both notif and content keys.

Depends on D8094

Test Plan

N/A, more design

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jun 6 2023, 10:39 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 6 2023, 10:39 AM
• jon added a child revision: D8127: [Identity] Implement upload one time keys endpoint.Jun 6 2023, 10:41 AM
Harbormaster completed remote builds in B20065: Diff 27495.Jun 6 2023, 10:56 AM
• jon requested review of this revision.Jun 6 2023, 10:56 AM
varun accepted this revision.Jun 6 2023, 11:55 AM
This revision is now accepted and ready to land.Jun 6 2023, 11:55 AM
ashoat requested changes to this revision.Jun 7 2023, 12:40 PM
ashoat added inline comments.
shared/protos/identity_client.proto
307 ↗(On Diff #27495)

In VerifyUserAccessTokenRequest, we call this signingPublicKey. Elsewhere we refer to it as deviceIDKey.

Can you make sure we're consistent and use a single name for this throughout the whole proto?

This revision now requires changes to proceed.Jun 7 2023, 12:40 PM
• jon requested review of this revision.Jun 8 2023, 4:57 PM
• jon marked an inline comment as done.
• jon added inline comments.
shared/protos/identity_client.proto
307 ↗(On Diff #27495)

Created: https://linear.app/comm/issue/ENG-4072

varun accepted this revision.Jun 8 2023, 10:31 PM
ashoat accepted this revision.Jun 9 2023, 7:22 AM
This revision is now accepted and ready to land.Jun 9 2023, 7:22 AM
Closed by commit rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys (authored by • jon). · Explain WhyJun 11 2023, 8:04 PM
This revision was automatically updated to reflect the committed changes.
• jon marked an inline comment as done.
• jon added a commit: rCOMMf6128a6c3c25: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.

Revision Contents
Changeset List

PathSize
shared/
protos/
8 lines

Diff 27631

View Options

shared/protos/identity_client.proto

Loading...