[Identity] Implement upload one time keys endpoint
ClosedPublic
Actions

Authored by • jon on Jun 6 2023, 10:41 AM.

Details

Reviewers

varun
bartek

Commits

rCOMM1a8763370094: [Identity] Implement upload one time keys endpoint

Summary

Implement upload one time keys endpoint and demonstrate with
integration test

https://linear.app/comm/issue/ENG-3943

Depends on D8126

Test Plan

setup localstack, run terraform locally, and start identity service

cd services/commtest && cargo test --test identity_access_tokens_tests

awslocal dynamodb scan --table-name identity-users
# should show one user having the new one-time keys

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jun 6 2023, 10:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 10:41 AM

Cleanup imports

• jon edited the test plan for this revision. (Show Details)Jun 6 2023, 10:57 AM

Harbormaster completed remote builds in B20066: Diff 27496.Jun 6 2023, 10:58 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 6 2023, 11:19 AM

Harbormaster failed remote builds in B20067: Diff 27497!

Harbormaster completed remote builds in B20067: Diff 27497.Jun 6 2023, 11:42 AM

• jon requested review of this revision.Jun 6 2023, 11:42 AM

just some clarifying questions inline

services/commtest/tests/identity_access_tokens_tests.rs
133 ↗	(On Diff #27497)	i don't understand why this call will fail if the keys were successfully added
services/identity/src/database.rs
237 ↗	(On Diff #27497)	is this line formatted correctly?

This revision is now accepted and ready to land.Jun 8 2023, 7:06 AM

Fix comment

Harbormaster completed remote builds in B20124: Diff 27571.Jun 8 2023, 5:33 PM

• jon added inline comments.Jun 11 2023, 2:49 PM

services/commtest/tests/identity_access_tokens_tests.rs
133 ↗	(On Diff #27497)	I think i re-wrote this comment incorrectly. Supposed to read "This send will fail if the one-time keys weren't successfully added"
services/identity/src/database.rs
237 ↗	(On Diff #27497)	yea, cargo fmt doesn't know what to do with long `format!` macros.