Page MenuHomePhabricator
Differential D8127

[Identity] Implement upload one time keys endpoint
ClosedPublic
Actions

Authored by • jon on Jun 6 2023, 10:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 3:25 PM
Unknown Object (File)
Mar 5 2025, 2:17 PM
Unknown Object (File)
Feb 28 2025, 1:21 PM
Unknown Object (File)
Feb 28 2025, 1:21 PM
Unknown Object (File)
Feb 28 2025, 1:20 PM
Unknown Object (File)
Feb 27 2025, 3:41 PM
Unknown Object (File)
Feb 27 2025, 3:41 PM
Unknown Object (File)
Jan 23 2025, 8:36 AM
View All 96 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM1a8763370094: [Identity] Implement upload one time keys endpoint
Summary

Implement upload one time keys endpoint and demonstrate with
integration test

https://linear.app/comm/issue/ENG-3943

Depends on D8126

Test Plan
  • setup localstack, run terraform locally, and start identity service
cd services/commtest && cargo test --test identity_access_tokens_tests

awslocal dynamodb scan --table-name identity-users
# should show one user having the new one-time keys

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jun 6 2023, 10:41 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 10:41 AM
• jon updated this revision to Diff 27497.Jun 6 2023, 10:46 AM

Cleanup imports

• jon edited the test plan for this revision. (Show Details)Jun 6 2023, 10:57 AM
Harbormaster completed remote builds in B20066: Diff 27496.Jun 6 2023, 10:58 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 6 2023, 11:19 AM
Harbormaster failed remote builds in B20067: Diff 27497!
Harbormaster completed remote builds in B20067: Diff 27497.Jun 6 2023, 11:42 AM
• jon requested review of this revision.Jun 6 2023, 11:42 AM
varun accepted this revision.Jun 8 2023, 7:06 AM

just some clarifying questions inline

services/commtest/tests/identity_access_tokens_tests.rs
133 ↗(On Diff #27497)

i don't understand why this call will fail if the keys were successfully added

services/identity/src/database.rs
237 ↗(On Diff #27497)

is this line formatted correctly?

This revision is now accepted and ready to land.Jun 8 2023, 7:06 AM
• jon updated this revision to Diff 27571.Jun 8 2023, 5:16 PM
• jon marked 2 inline comments as done.
• jon edited the test plan for this revision. (Show Details)

Fix comment

Harbormaster completed remote builds in B20124: Diff 27571.Jun 8 2023, 5:33 PM
• jon added inline comments.Jun 11 2023, 2:49 PM
services/commtest/tests/identity_access_tokens_tests.rs
133 ↗(On Diff #27497)

I think i re-wrote this comment incorrectly. Supposed to read "This send will fail if the one-time keys weren't successfully added"

services/identity/src/database.rs
237 ↗(On Diff #27497)

yea, cargo fmt doesn't know what to do with long format! macros.

Closed by commit rCOMM1a8763370094: [Identity] Implement upload one time keys endpoint (authored by • jon). · Explain WhyJun 11 2023, 8:04 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM1a8763370094: [Identity] Implement upload one time keys endpoint.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
27 lines
identity/
src/
38 lines
45 lines

Diff 27632

View Options

services/commtest/tests/identity_access_tokens_tests.rs

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines
View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines): ReduceMessageStoreResult {
) { ) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible( const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload, action.payload,
newThreadInfos, newThreadInfos,
); );
const { localID, threadID } = payload; const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`); invariant(localID, `localID should be set on ${action.type}`);
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
if (!messageStore.messages[localID]) {
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
}
const messageStoreOperations = [ const messageStoreOperations = [
{ {
type: 'replace', type: 'replace',
payload: { id: localID, messageInfo: payload }, payload: { id: localID, messageInfo: payload },
}, },
]; ];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const now = Date.now(); const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? []; let updatedThreads;
let local = { ...messageStore.local };
if (messageStore.messages[localID]) { if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload }; const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy( local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID, (localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local); )(messageStore.local);
const thread = messageStore.threads[threadID]; const thread = messageStore.threads[threadID];
const threads = { updatedThreads = {
...messageStore.threads,
[threadID]: { [threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs), messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true, startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now, lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now, lastPruned: thread?.lastPruned ?? now,
}, },
}; };
return { } else {
messageStoreOperations, updatedThreads = {
messageStore: { [threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}
for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}
const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? { ? {
...messageStore.threads[threadID], ...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs], messageIDs: [localID, ...messageIDs],
} }
: { : {
messageIDs: [localID], messageIDs: [localID],
startReached: true, startReached: true,
lastNavigatedTo: now, lastNavigatedTo: now,
lastPruned: now, lastPruned: now,
},
}; };
}
return { const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads, ...messageStore.threads,
[threadID]: threadState, ...updatedThreads,
};
messageStoreOperations.push({
type: 'replace_threads',
payload: {
threads: { ...updatedThreads },
}, },
local: messageStore.local, });
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);
const newMessageStore = {
messages: processedMessageStore.messages,
threads,
local,
currentAsOf: messageStore.currentAsOf, currentAsOf: messageStore.currentAsOf,
}, };
assertMessageStoreThreadsAreEqual(
processedMessageStore,
newMessageStore,
action.type,
);
return {
messageStoreOperations,
messageStore: newMessageStore,
}; };
} else if ( } else if (
action.type === sendTextMessageActionTypes.failed || action.type === sendTextMessageActionTypes.failed ||
action.type === sendMultimediaMessageActionTypes.failed action.type === sendMultimediaMessageActionTypes.failed
) { ) {
const { localID } = action.payload; const { localID } = action.payload;
return { return {
messageStoreOperations: [], messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines